Blame 0007-Don-t-call-insert-from-Q_ASSERT-breaks-unit-tests-in.patch
|
Rex Dieter |
8acc3d6 |
From c516ec5c28d603aea0df6165f66a3a5d0a0191c4 Mon Sep 17 00:00:00 2001
|
|
Rex Dieter |
8acc3d6 |
From: =?UTF-8?q?Dan=20Vr=C3=A1til?= <dvratil@redhat.com>
|
|
Rex Dieter |
8acc3d6 |
Date: Fri, 19 Sep 2014 10:50:23 +0200
|
|
Rex Dieter |
8acc3d6 |
Subject: [PATCH 7/9] Don't call insert() from Q_ASSERT - breaks unit-tests in
|
|
Rex Dieter |
8acc3d6 |
Release mode
|
|
Rex Dieter |
8acc3d6 |
|
|
Rex Dieter |
8acc3d6 |
---
|
|
Rex Dieter |
8acc3d6 |
server/tests/unittest/collectionreferencetest.cpp | 6 ++++--
|
|
Rex Dieter |
8acc3d6 |
1 file changed, 4 insertions(+), 2 deletions(-)
|
|
Rex Dieter |
8acc3d6 |
|
|
Rex Dieter |
8acc3d6 |
diff --git a/server/tests/unittest/collectionreferencetest.cpp b/server/tests/unittest/collectionreferencetest.cpp
|
|
Rex Dieter |
8acc3d6 |
index 1700c75..1b10c55 100644
|
|
Rex Dieter |
8acc3d6 |
--- a/server/tests/unittest/collectionreferencetest.cpp
|
|
Rex Dieter |
8acc3d6 |
+++ b/server/tests/unittest/collectionreferencetest.cpp
|
|
Rex Dieter |
8acc3d6 |
@@ -45,7 +45,8 @@ public:
|
|
Rex Dieter |
8acc3d6 |
Resource res;
|
|
Rex Dieter |
8acc3d6 |
res.setId(1);
|
|
Rex Dieter |
8acc3d6 |
res.setName(QLatin1String(name));
|
|
Rex Dieter |
8acc3d6 |
- Q_ASSERT(res.insert());
|
|
Rex Dieter |
8acc3d6 |
+ const bool success = res.insert();
|
|
Rex Dieter |
8acc3d6 |
+ Q_ASSERT(success);
|
|
Rex Dieter |
8acc3d6 |
mResource = res;
|
|
Rex Dieter |
8acc3d6 |
return res;
|
|
Rex Dieter |
8acc3d6 |
}
|
|
Rex Dieter |
8acc3d6 |
@@ -57,7 +58,8 @@ public:
|
|
Rex Dieter |
8acc3d6 |
col.setName(QLatin1String(name));
|
|
Rex Dieter |
8acc3d6 |
col.setRemoteId(QLatin1String(name));
|
|
Rex Dieter |
8acc3d6 |
col.setResource(mResource);
|
|
Rex Dieter |
8acc3d6 |
- Q_ASSERT(col.insert());
|
|
Rex Dieter |
8acc3d6 |
+ const bool success = col.insert();
|
|
Rex Dieter |
8acc3d6 |
+ Q_ASSERT(success);
|
|
Rex Dieter |
8acc3d6 |
return col;
|
|
Rex Dieter |
8acc3d6 |
}
|
|
Rex Dieter |
8acc3d6 |
|
|
Rex Dieter |
8acc3d6 |
--
|
|
Rex Dieter |
8acc3d6 |
1.9.3
|
|
Rex Dieter |
8acc3d6 |
|