#25 Minor spec file optimizations
Opened 3 years ago by robert. Modified 3 years ago
rpms/ robert/bash optimizations  into  rawhide

file modified
+10 -9
@@ -8,11 +8,11 @@ 

  Summary: The GNU Bourne Again shell

  Release: 1%{?dist}

  License: GPLv3+

- Url: https://www.gnu.org/software/bash

+ URL: https://www.gnu.org/software/bash/

  Source0: https://ftp.gnu.org/gnu/bash/bash-%{baseversion}.tar.gz

  

  # For now there isn't any doc

- #Source2: ftp://ftp.gnu.org/gnu/bash/bash-doc-%%{version}.tar.gz

+ #Source2: https://ftp.gnu.org/gnu/bash/bash-doc-%%{version}.tar.gz

  

  Source1: dot-bashrc

  Source2: dot-bash_profile
@@ -82,7 +82,7 @@ 

  # this patch disables it

  Patch127: bash-4.4-no-loadable-builtins.patch

  

- BuildRequires:  gcc

+ BuildRequires: gcc

  BuildRequires: texinfo bison

  BuildRequires: ncurses-devel

  BuildRequires: autoconf, gettext
@@ -109,6 +109,7 @@ 

  %package doc

  Summary: Documentation files for %{name}

  Requires: %{name} = %{version}-%{release}

+ BuildArch: noarch

  

  %description doc

  This package contains documentation files for %{name}.
@@ -147,7 +148,7 @@ 

  

  %make_install install-headers

  

- mkdir -p %{buildroot}/%{_sysconfdir}

+ mkdir -p %{buildroot}%{_sysconfdir}

  

  # make manpages for bash builtins as per suggestion in DOC/README

  pushd doc
@@ -178,9 +179,9 @@ 

  ln -s bash.1 %{buildroot}%{_mandir}/man1/sh.1

  

  # Not for printf, true and false (conflict with coreutils)

- rm -f %{buildroot}/%{_mandir}/man1/printf.1

- rm -f %{buildroot}/%{_mandir}/man1/true.1

- rm -f %{buildroot}/%{_mandir}/man1/false.1

+ rm -f %{buildroot}%{_mandir}/man1/printf.1

+ rm -f %{buildroot}%{_mandir}/man1/true.1

+ rm -f %{buildroot}%{_mandir}/man1/false.1

  

  ln -sf bash %{buildroot}%{_bindir}/sh

  rm -f %{buildroot}%{_infodir}/dir
@@ -192,7 +193,7 @@ 

  mv %{buildroot}%{_bindir}/bashbug \

     %{buildroot}%{_bindir}/bashbug-"${LONG_BIT}"

  ln -s bashbug-"${LONG_BIT}" %{buildroot}%{_bindir}/bashbug

- ln -s bashbug.1 %{buildroot}/%{_mandir}/man1/bashbug-"$LONG_BIT".1

+ ln -s bashbug.1 %{buildroot}%{_mandir}/man1/bashbug-"$LONG_BIT".1

  

  # Fix missing sh-bangs in example scripts (bug #225609).

  for script in \
@@ -222,7 +223,7 @@ 

  

  # copy doc to /usr/share/doc

  cat /dev/null > %{name}-doc.files

- mkdir -p %{buildroot}/%{_pkgdocdir}/doc

+ mkdir -p %{buildroot}%{_pkgdocdir}/doc

  # loadables aren't buildable

  rm -rf examples/loadables

  for file in CHANGES COMPAT NEWS NOTES POSIX RBASH README examples

no initial comment

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci