PR#2: Do not set LD_LIBRARY_PATH in %check - rpms/bigloo

rpms / bigloo

#2 Do not set LD_LIBRARY_PATH in %check

Closed 5 years ago by jjames. Opened 5 years ago by scfc.

https://github.com/scfc/fedora-rpms-bigloo do-not-set-ld-library-path-in-check into master

Do not set LD_LIBRARY_PATH in %check

Tim Landscheidt • 5 years ago

409d976

bigloo.spec

file modified

+4 -2

		`@@ -19,7 +19,7 @@`

		`Name: bigloo`
		`Version: 4.3c`
		`- Release: 1%{?patch_ver:.%{patch_ver}}%{?prerel:.%{prerel}}%{?dist}`
		`+ Release: 2%{?patch_ver:.%{patch_ver}}%{?prerel:.%{prerel}}%{?dist}`
		`Summary: A compiler for the Scheme programming language`

		`License: GPLv2+`
		`@@ -272,7 +272,6 @@`


		`%check`
		`- export LD_LIBRARY_PATH=$PWD/inplace/%{_libdir}/bigloo/%{version}`
		`make test`


		`@@ -301,6 +300,9 @@`


		`%changelog`
		`+ * Sat Jan 05 2019 Tim Landscheidt <tim@tim-landscheidt.de> - 4.3c-2`
		`+ - Do not set LD_LIBRARY_PATH in %%check`
		`+`
		`* Sat Sep 15 2018 Jerry James <loganjerry@gmail.com> - 4.3c-1`
		`- Update to 4.3c`

no initial comment

scfc commented 5 years ago

All tests are run via bglrun.sh which sets (and thus overwrites) LD_LIBRARY_PATH with the absolute path to the built libraries.

jjames commented 5 years ago

Thanks for the fix. I am currently working on an update to 4.3e, so I am not going to build just yet, but I will go ahead and merge.

jjames commented 5 years ago

Except this commit conflicts with the previous pull request, due to both changing the Release field. I will go ahead and commit this without the Release field change.

Pull-Request has been closed by jjames

5 years ago

scfc commented 5 years ago

Yep, that's unfortunately the problem with spec files: Either one has to submit a chain of commits (or squash them all together) which makes discussion of isolated changes complicated, or there will be conflicts. Hopefully someday someone will write a Git merge driver for spec files.

Metadata

Assignee

None

Tags

No Tags

Changes Summary 1

+4 -2

file changed

bigloo.spec

rpms / bigloo

Source Code

#2 Do not set LD_LIBRARY_PATH in %check Closed 5 years ago by jjames. Opened 5 years ago by scfc. https://github.com/scfc/fedora-rpms-bigloo do-not-set-ld-library-path-in-check into master

Metadata

Changes Summary 1

#2 Do not set LD_LIBRARY_PATH in %check

Closed 5 years ago by jjames. Opened 5 years ago by scfc.

https://github.com/scfc/fedora-rpms-bigloo do-not-set-ld-library-path-in-check into master