PR#1: Don't drag in NetworkManager components - rpms/control-center

rpms / control-center

#1 Don't drag in NetworkManager components

Closed 3 years ago by catanzaro. Opened 6 years ago by lkundrak.

rpms/ lkundrak/control-center lr/nm-ce into rawhide

Don't drag in NetworkManager components

Lubomir Rintel • 6 years ago

88463fe

control-center.spec

file modified

+4 -3

		`@@ -93,9 +93,6 @@`
		`Requires: vino`
		`# For the printers panel`
		`Requires: cups-pk-helper`
		`- # For the network panel`
		`- Requires: nm-connection-editor`
		`- Requires: NetworkManager-wifi`
		`# For the info/details panel`
		`Requires: glx-utils`
		`Requires: switcheroo-control`
		`@@ -197,6 +194,10 @@`


		`%changelog`
		`+ * Sun Mar 18 2018 Lubomir Rintel <lkundrak@v3.sk> - 1:3.28.0-2`
		`+ - Don't drag in NetworkManager-wifi`
		`+ - nm-connection-editor is no longer depended on`
		`+`
		`* Mon Mar 12 2018 Kalev Lember <klember@redhat.com> - 1:3.28.0-1`
		`- Update to 3.28.0`

lkundrak commented 6 years ago

nm-connection-editor is no longer user by the control center for some
time.

Also, NetworkManager-wifi doesn't seem to be necessary in all cases --
it drags in the wpa_supplicant with a handful of other dependent
packages, but is not strictly necessary for wired-only setups.
In any case, it's dragged in by the comps wherever it makes sense to
have it by default (Workstation spin).

catanzaro commented 6 years ago

You can see that nm-connection-editotr is definitely still required by searching the code. It's still used in net-connection-editor.c, net-device-wifi.c, and net-device.c. So that Requires needs to stay.

Is there a graceful fallback behavior when NetworkManager-wifi is not installed? If nothing seems broken and the Wi-Fi panel is just disabled, then that seems fine. I would change it from Requires to Recommends, rather than dropping it completely.