#23 Add a Requires for lua-srpm-macros
Merged 3 years ago by salimma. Opened 3 years ago by salimma.
rpms/ salimma/epel-rpm-macros epel8-lua-macros  into  epel8

file modified
+6 -1
@@ -1,6 +1,6 @@ 

  Name:           epel-rpm-macros

  Version:        8

- Release:        16

+ Release:        17

  Summary:        Extra Packages for Enterprise Linux RPM macros

  

  Group:          System Environment/Base
@@ -28,6 +28,8 @@ 

  Requires:       redhat-release >= %{version}

  # For FPC buildroot macros

  Requires:       fpc-srpm-macros

+ # For Lua SRPM macros

+ Requires:       lua-srpm-macros

  # For python buildroot macros

  Requires:       python-srpm-macros

  # Since the RHEL python-devel package doesn't require them, bring them in here
@@ -83,6 +85,9 @@ 

  

  

  %changelog

+ * Tue Sep  8 2020 Michel Alexandre Salim <salimma@fedoraproject.org> - 8-17

+ - Add a Requires for lua-srpm-macros

+ 

  * Thu Jul 30 2020 Neal Gompa <ngompa13@gmail.com> - 8-16

  - Use legacy behavior for cmake-configure

  

I'd like to get this reviewed even though I have commit access as a provenpackager; if this is fine, I plan to merge in the same change for epel8-playground, epel7 and el6.

Rationale: Lua macros are currently shipped in lua-devel in stable Fedora releases and EL8. It makes it hard to use the few macros we need at SRPM creation time, and also to update them without rebuilding lua (this is also why EL7 and EL6 don't have Lua macros).

Fixing EL8 to remove the macros from lua-devel (part of RHEL) would be difficult so for EPEL8 we're only pulling in lua-srpm-macros (some definitions would be duplicated but that's fine), but for EL6 and EL7 they never have the macros shipped so we can modify epel-rpm-macros to pull in both.

Signed-off-by: Michel Alexandre Salim salimma@fedoraproject.org

rebased onto d524b421a3e506917d629bb7d919b9db0c3bc920

3 years ago

Seems fine to me, unless lua-srpm-macros pull in a bunch of things (which they shouldn't).

+1 to merge and build.

rebased onto d08dbfe

3 years ago

Pull-Request has been merged by salimma

3 years ago