rpms / epel-rpm-macros

Clone
Source Code
GIT

#59 Add perl-generators-epel to the buildroot (EPEL 9)
Merged a year ago by kevin. Opened a year ago by jplesnik.
Unknown source epel9  into  epel9

file modified
+7 -1 
@@ -1,6 +1,6 @@
 

  Name:           epel-rpm-macros
 

  Version:        9
 

- Release:        7%{dist}
 

+ Release:        8%{dist}
 

  Summary:        Extra Packages for Enterprise Linux RPM macros
 

  

  License:        GPLv2
 
@@ -31,6 +31,9 @@
 

  # Just like in Fedora, only the minimal -srpm-macros are needed in the buildroot.
 

  # The rest of the macros are pulled in dynamically.
 

  Requires:       go-srpm-macros-epel
 

+ # Provides backport from Fedora's perl-generators related to proposal
 

+ # https://fedoraproject.org/wiki/Changes/Perl_replace_MODULE_COMPAT_by_generator
 

+ Requires:       (perl-generators-epel if perl-generators)
 

  

  %description
 

  This package contains the Extra Packages for Enterprise Linux (EPEL) RPM
 
@@ -60,6 +63,9 @@
 

  

  

  %changelog
 

+ * Mon Jan 23 2023 Jitka Plesnikova <jplesnik@redhat.com> - 9-8
 

+ - Add perl-generators-epel to the buildroot
 

+ 

  * Fri Sep 02 2022 Maxwell G <gotmax@e.email> - 9-7
 

  - Add go-srpm-macros-epel to the buildroot

perl-generators-epel provides backport from Fedora's perl-generators related to proposal
https://fedoraproject.org/wiki/Changes/Perl_replace_MODULE_COMPAT_by_generator

It would help maintainers who prefer one version of the spec file for all releases.

Build succeeded.

Build succeeded.

Should this be Requires: (perl-generators-epel if perl-generators)?

Looking at the code

%__perlcompat_requires() %{lua:
    local path = rpm.expand('%1')
    local perl_ver = rpm.expand('%{perl_version}')
    if path:match('.+%.so$') and perl_ver ~= "" then
       print('perl(:MODULE_COMPAT_' .. perl_ver .. ')')
    else
       print('perl-libs')
    end
}

when would %{perl_version} be an empty string? Are you just trying to check whether it's defined?
Edited a year ago by gotmax23

Looking at the code

%__perlcompat_requires() %{lua: local path = rpm.expand('%1') local perl_ver = rpm.expand('%{perl_version}') if path:match('.+%.so$') and perl_ver ~= "" then print('perl(:MODULE_COMPAT_' .. perl_ver .. ')') else print('perl-libs') end }

when would %{perl_version} be an empty string? Are you just trying to check whether it's defined?

%{perl_version} is defined in package perl-macros, which is listed in run-requires of the perl-generators-epel.

I'm asking about if path:match('.+%.so$') and perl_ver ~= "". What is perl_ver ~= "" checking for?

Should this be Requires: (perl-generators-epel if perl-generators)?

I'm sorry, but I haven't used this condition yet and I don't know how it works.

perl-generators is listed as build-requires for all perl modules.

I'm asking about if path:match('.+%.so$') and perl_ver ~= "". What is perl_ver ~= "" checking for?

perl_ver ~= "" is checking that perl_ver is not empty string, so perl(MODULE_COMPAT_XXX) will have valid value.

Should this be Requires: (perl-generators-epel if perl-generators)?

I'm sorry, but I haven't used this condition yet and I don't know how it works.

perl-generators is listed as build-requires for all perl modules.

Effectively, this makes it so perl-generators-epel shadows perl-generators from RHEL and is only pulled in when a specfile has BuildRequires: perl-generators. This avoids including perl-generators, perl-macros, and their dependencies in the default buildroot.

perl_ver ~= "" is checking that perl_ver is not empty string, so perl(MODULE_COMPAT_XXX) will have valid value.

Ack.

1 new commit added

  • Add boolean operator to perl-generators-epel
a year ago

Should this be Requires: (perl-generators-epel if perl-generators)?

I'm sorry, but I haven't used this condition yet and I don't know how it works.

perl-generators is listed as build-requires for all perl modules.

Effectively, this makes it so perl-generators-epel shadows perl-generators from RHEL and is only pulled in when a specfile has BuildRequires: perl-generators. This avoids including perl-generators, perl-macros, and their dependencies in the default buildroot.

Will it work also for epel 8?

Build succeeded.

Will it work also for epel 8?

It'll work for EPEL 8 but not for EPEL 7.

It'll work for EPEL 8 but not for EPEL 7.
I tested it and I've already updated the pull request for EPEL 8.

Who could merge these pull requests?

I can merge them, but there's some other ones pending that will make this conflict. If you can rebase after that, that would be great.

Nevermind, looks like that PR was non mergable. :)

Pull-Request has been merged by kevin
a year ago
Metadata
None
No Tags
Changes Summary 1
+7 -1
file changed
epel-rpm-macros.spec
Powered by Pagure 5.14.1
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.