#206 Drop 'Edition' branding for Cloud
Closed 2 years ago by zbyszek. Opened 2 years ago by sgallagh.
rpms/ sgallagh/fedora-release rawhide  into  rawhide

file modified
+4 -4
@@ -218,7 +218,7 @@ 

  

  

  %package identity-cloud

- Summary:        Package providing the identity for Fedora Cloud Edition

+ Summary:        Package providing the identity for Fedora Cloud

  

  RemovePathPostfixes: .cloud

  Provides:       fedora-release-identity = %{version}-%{release}
@@ -227,7 +227,7 @@ 

  

  %description identity-cloud

  Provides the necessary files for a Fedora installation that is identifying

- itself as Fedora Cloud Edition.

+ itself as Fedora Cloud.

  %endif

  

  
@@ -941,9 +941,9 @@ 

  # Cloud

  cp -p os-release \

        %{buildroot}%{_prefix}/lib/os-release.cloud

- echo "VARIANT=\"Cloud Edition\"" >> %{buildroot}%{_prefix}/lib/os-release.cloud

+ echo "VARIANT=\"Cloud\"" >> %{buildroot}%{_prefix}/lib/os-release.cloud

  echo "VARIANT_ID=cloud" >> %{buildroot}%{_prefix}/lib/os-release.cloud

- sed -i -e "s|(%{release_name}%{?prerelease})|(Cloud Edition%{?prerelease})|g" %{buildroot}%{_prefix}/lib/os-release.cloud

+ sed -i -e "s|(%{release_name}%{?prerelease})|(Cloud%{?prerelease})|g" %{buildroot}%{_prefix}/lib/os-release.cloud

  sed -e "s#\$version#%{bug_version}#g" -e 's/$edition/Cloud/;s/<!--.*-->//;/^$/d' %{SOURCE20} > %{buildroot}%{_swidtagdir}/org.fedoraproject.Fedora-edition.swidtag.cloud

  %endif

  

We should probably run the name by the Cloud SIG? For a while, we were trying to push for "Fedora Cloud Base Image" as the whole name.

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

What's the context on this? Cloud SIG definitely considers Cloud an Edition, so this is kind of a surprise, as I don't recall us receiving feedback otherwise. Was there a meeting where this was discussed that we missed?

@dcavalca @davdunc I added some context in that bug, and have some more to say that I'll also link in a bit...

Based on the discussion linked above, close this?

Based on the discussion linked above, close this?

I think so, yeah. We can reopen if things fall apart. :)

Pull-Request has been closed by zbyszek

2 years ago
Metadata