Martin Stransky 6098a70
# HG changeset patch
Martin Stransky 6098a70
# Parent a0787486ecf5950b5753d265a15e0f9a3b4e2ad4
Martin Stransky 6098a70
# User Martin Stransky <stransky@redhat.com>
Martin Stransky 6098a70
Bug 1161056 - Gtk3 - use sMozWindowBackground colors for combobox background. r=karlt
Martin Stransky 6098a70
Martin Stransky 6098a70
diff --git a/widget/gtk/nsLookAndFeel.cpp b/widget/gtk/nsLookAndFeel.cpp
Martin Stransky 6098a70
--- a/widget/gtk/nsLookAndFeel.cpp
Martin Stransky 6098a70
+++ b/widget/gtk/nsLookAndFeel.cpp
Martin Stransky 6098a70
@@ -96,16 +96,17 @@ nsLookAndFeel::NativeGetColor(ColorID aI
Martin Stransky 6098a70
     case eColorID_WidgetBackground:
Martin Stransky 6098a70
     case eColorID_TextBackground:
Martin Stransky 6098a70
     case eColorID_activecaption: // active window caption background
Martin Stransky 6098a70
     case eColorID_appworkspace: // MDI background color
Martin Stransky 6098a70
     case eColorID_background: // desktop background
Martin Stransky 6098a70
     case eColorID_window:
Martin Stransky 6098a70
     case eColorID_windowframe:
Martin Stransky 6098a70
     case eColorID__moz_dialog:
Martin Stransky 6098a70
+    case eColorID__moz_combobox:
Martin Stransky 6098a70
         aColor = sMozWindowBackground;
Martin Stransky 6098a70
         break;
Martin Stransky 6098a70
     case eColorID_WindowForeground:
Martin Stransky 6098a70
     case eColorID_WidgetForeground:
Martin Stransky 6098a70
     case eColorID_TextForeground: 
Martin Stransky 6098a70
     case eColorID_captiontext: // text in active window caption, size box, and scrollbar arrow box (!)
Martin Stransky 6098a70
     case eColorID_windowtext:
Martin Stransky 6098a70
     case eColorID__moz_dialogtext:
Martin Stransky 6098a70
@@ -399,19 +400,21 @@ nsLookAndFeel::NativeGetColor(ColorID aI
Martin Stransky 6098a70
         aColor = sOddCellBackground;
Martin Stransky 6098a70
         break;
Martin Stransky 6098a70
     case eColorID__moz_nativehyperlinktext:
Martin Stransky 6098a70
         aColor = sNativeHyperLinkText;
Martin Stransky 6098a70
         break;
Martin Stransky 6098a70
     case eColorID__moz_comboboxtext:
Martin Stransky 6098a70
         aColor = sComboBoxText;
Martin Stransky 6098a70
         break;
Martin Stransky 6098a70
+#if (MOZ_WIDGET_GTK == 2)
Martin Stransky 6098a70
     case eColorID__moz_combobox:
Martin Stransky 6098a70
         aColor = sComboBoxBackground;
Martin Stransky 6098a70
         break;
Martin Stransky 6098a70
+#endif
Martin Stransky 6098a70
     case eColorID__moz_menubartext:
Martin Stransky 6098a70
         aColor = sMenuBarText;
Martin Stransky 6098a70
         break;
Martin Stransky 6098a70
     case eColorID__moz_menubarhovertext:
Martin Stransky 6098a70
         aColor = sMenuBarHoverText;
Martin Stransky 6098a70
         break;
Martin Stransky 6098a70
     default:
Martin Stransky 6098a70
         /* default color is BLACK */
Martin Stransky 6098a70
@@ -1143,25 +1146,21 @@ nsLookAndFeel::Init()
Martin Stransky 6098a70
 #else
Martin Stransky 6098a70
     // Button text, background, border
Martin Stransky 6098a70
     style = gtk_widget_get_style_context(label);
Martin Stransky 6098a70
     gtk_style_context_get_color(style, GTK_STATE_FLAG_NORMAL, &color;;
Martin Stransky 6098a70
     sButtonText = GDK_RGBA_TO_NS_RGBA(color);
Martin Stransky 6098a70
     gtk_style_context_get_color(style, GTK_STATE_FLAG_PRELIGHT, &color;;
Martin Stransky 6098a70
     sButtonHoverText = GDK_RGBA_TO_NS_RGBA(color);
Martin Stransky 6098a70
 
Martin Stransky 6098a70
-    // Combobox label and background colors
Martin Stransky 6098a70
+    // Combobox text color
Martin Stransky 6098a70
     style = gtk_widget_get_style_context(comboboxLabel);
Martin Stransky 6098a70
     gtk_style_context_get_color(style, GTK_STATE_FLAG_NORMAL, &color;;
Martin Stransky 6098a70
     sComboBoxText = GDK_RGBA_TO_NS_RGBA(color);
Martin Stransky 6098a70
 
Martin Stransky 6098a70
-    style = gtk_widget_get_style_context(combobox);
Martin Stransky 6098a70
-    gtk_style_context_get_background_color(style, GTK_STATE_FLAG_NORMAL, &color;;
Martin Stransky 6098a70
-    sComboBoxBackground = GDK_RGBA_TO_NS_RGBA(color);
Martin Stransky 6098a70
-
Martin Stransky 6098a70
     // Menubar text and hover text colors    
Martin Stransky 6098a70
     style = gtk_widget_get_style_context(menuBar);
Martin Stransky 6098a70
     gtk_style_context_get_color(style, GTK_STATE_FLAG_NORMAL, &color;;
Martin Stransky 6098a70
     sMenuBarText = GDK_RGBA_TO_NS_RGBA(color);
Martin Stransky 6098a70
     gtk_style_context_get_color(style, GTK_STATE_FLAG_PRELIGHT, &color;;
Martin Stransky 6098a70
     sMenuBarHoverText = GDK_RGBA_TO_NS_RGBA(color);
Martin Stransky 6098a70
 
Martin Stransky 6098a70
     // GTK's guide to fancy odd row background colors: