remove gdb-container-rh-pkg.patch
Remove gdb-container-rh-pkg.patch. This patch added a warning if the
gdbserver doesn't support the qXfer:exec-file:read packet, that is,
the packet which allows GDB to read the executable from the gdbserver.
The warning text is:
Remote gdbserver does not support determining executable automatically.
RHEL <=6.8 and <=7.2 versions of gdbserver do not support such automatic executable detection.
The following versions of gdbserver support it:
- Upstream version of gdbserver (unsupported) 7.10 or later
- Red Hat Developer Toolset (DTS) version of gdbserver from DTS 4.0 or later (only on x86_64)
- RHEL-7.3 versions of gdbserver (on any architecture)
Clearly the concern here is a user using RHEL 6.8 or earlier, or RHEL
7.2 or earlier. However, it is my understanding that all of these
versions of RHEL are no longer supported.
As such I think we should drop this patch. For Fedora this is a
non-issue, any gdbserver of a similar vintage will support the
required packets, and the warning (which talks about RHEL) doesn't
make much sense for Fedora anyway.
For RHEL our expectation is that customers will use a supported
version of gdbserver, and any supported gdbserver should now support
the required packets.
If there are issues that crop up due to this warning being removed
then we might consider upstreaming a more general warning, something
like:
Remote target doesn't support reading the executable.
But there are lots of optional features we don't warn about, so I'd
only propose doing that if we get lots of confused users
complaining (which I'm not expecting).