PR#1: Update Python 2 dependency declarations to new packaging standards - rpms/ghc

rpms / ghc

#1 Update Python 2 dependency declarations to new packaging standards

Closed 5 years ago by churchyard. Opened 6 years ago by ishcherb.

rpms/ ishcherb/ghc pyambiguous into master

Update Python 2 dependency declarations to new packaging standards

Iryna Shcherbina • 6 years ago

16d098c

ghc.spec

file modified

+6 -2

		`@@ -27,7 +27,7 @@`
		`# - release can only be reset if all library versions get bumped simultaneously`
		`# (sometimes after a major release)`
		`# - minor release numbers for a branch should be incremented monotonically`
		`- Release: 68%{?dist}`
		`+ Release: 69%{?dist}`
		`Summary: Glasgow Haskell Compiler`

		`License: BSD and HaskellReport`
		`@@ -85,7 +85,7 @@`
		`%endif`
		`%if %{with docs}`
		`# for /usr/bin/sphinx-build`
		`- BuildRequires: python-sphinx`
		`+ BuildRequires: %{_bindir}/sphinx-build`
		`%endif`
		`%ifarch %{ghc_llvm_archs}`
		`BuildRequires: llvm%{llvm_major}`
		`@@ -622,6 +622,10 @@`


		`%changelog`
		`+ * Mon Jun 04 2018 Iryna Shcherbina <shcherbina.iryna@gmail.com> - 8.2.2-69`
		`+ - Update Python 2 dependency declarations to new packaging standards`
		`+ (See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3)`
		`+`
		`* Mon May 28 2018 Jens Petersen <petersen@redhat.com> - 8.2.2-68`
		`- fix sphinx-build version detection`
		`- merge bcond for haddock and manual`

ishcherb commented 6 years ago

This package uses names with ambiguous python- prefix in requirements.

According to Fedora Packaging guidelines for Python, packages must use names with either python2- or python3- prefix in requirements where available.
We are aiming to rename python-* dependencies to python2-*, so we can later switch the python-* namespace to Python 3.

This PR is part of Fedora's Switch to Python 3 effort.

Note that, although this PR was created automatically, we will respond to any comments or issues which you might find with it. We will keep the PR open for review for a week, and if there's no feedback we'll merge it. There is no need to build the package right after merge, this change can wait for the next package rebuild.
The local mock build passed, for Koji scratch build please see simple-koji-ci result.

This PR was opened automatically, for source code see here

petersen commented 6 years ago

Okay, I was trying to avoid a file-based dependency, but maybe it is better?
I actually had python3- there recently then realised sphinx-build is in python2-, then I switched to python2-, and then I figured python- will probably continue to provide /usr/bin/python-sphinx so I regressed back to that... but I understand python- is deprecated currently.

churchyard commented 6 years ago

Why don't we build the docs with Python 3 Sphinx explicitly instead?

churchyard commented 5 years ago

bump here?

petersen commented 5 years ago

Perhaps I misunderstood your previous comment, which I took to mean "why doesn't python3-sphinx provide /usr/bin/sphinx-build?
But you were asking me why don't I build with sphinx-build-3? I probably can...

So /usr/bin/sphinx-build should be considered deprecated?

churchyard commented 5 years ago

So /usr/bin/sphinx-build should be considered deprecated?

Not necessarily, but using Python 3 explicitly is always better. JIf you want to avoid a file-based dependency, you need to BR python3-sphinx or python2-sphinx explicitly. Once you are there, why not to switch to Python 3 entirely.

Shall I post another PR?

petersen commented 5 years ago

If you are backing it with a test build then sure, thanks.

(I seem to remember that previously python3-sphinx was detected correctly, but I am not sure if that still holds.)

Edited 5 years ago by petersen

churchyard commented 5 years ago

https://src.fedoraproject.org/rpms/ghc/pull-request/2