PR#3: Fix requirement for %preun (instead of %postun) scriptlet - rpms/ghc

rpms / ghc

#3 Fix requirement for %preun (instead of %postun) scriptlet

Closed 3 years ago by petersen. Opened 5 years ago by scfc.

Unknown source fix-requirements-for-scriptlets into master

Fix requirement for %preun (instead of %postun) scriptlet

Tim Landscheidt • 4 years ago

b4b05f0

ghc.spec

file modified

+5 -2

		`@@ -39,7 +39,7 @@`
		`# - release can only be reset if all library versions get bumped simultaneously`
		`# (sometimes after a major release)`
		`# - minor release numbers for a branch should be incremented monotonically`
		`- Release: 75%{?dist}`
		`+ Release: 76%{?dist}`
		`Summary: Glasgow Haskell Compiler`

		`License: BSD and HaskellReport`
		`@@ -159,7 +159,7 @@`
		`Requires: ghc-base-devel%{?_isa}`
		`# for alternatives`
		`Requires(post): %{_sbindir}/update-alternatives`
		`- Requires(postun): %{_sbindir}/update-alternatives`
		`+ Requires(preun): %{_sbindir}/update-alternatives`
		`# added in f14`
		`Obsoletes: ghc-doc < 6.12.3-4`
		`%if %{without docs}`
		`@@ -666,6 +666,9 @@`


		`%changelog`
		`+ * Fri Jun 28 2019 Tim Landscheidt <tim@tim-landscheidt.de> - 8.4.4-76`
		`+ - Fix requirement for %%preun (instead of %%postun) scriptlet`
		`+`
		`* Fri Jun 28 2019 Jens Petersen <petersen@redhat.com> - 8.4.4-75`
		`- add transfiletriggers that will replace individual post/postun scriptlets`

no initial comment

petersen commented 5 years ago

Thanks for this - any explanation or reference for this would be helpful

scfc commented 4 years ago

Commit 72942f4 added requirements on chkconfig for the %post and %preun scriptlets that call update-alternatives (which got amended to %{_sbindir}/update-alternatives by commit 20edd0d) to fix bug #753661. However, the requirement for the %preun scriptlet was incorrectly specified as a requirement for a (non-existing) %postun scriptlet. This commit fixes that.