ed1787d
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
ed1787d
From: Daniel Axtens <dja@axtens.net>
ed1787d
Date: Thu, 25 Nov 2021 02:22:45 +1100
ed1787d
Subject: [PATCH] mm: Document GRUB internal memory management structures
ed1787d
ed1787d
I spent more than a trivial quantity of time figuring out pre_size and
ed1787d
whether a memory region's size contains the header cell or not.
ed1787d
ed1787d
Document the meanings of all the properties. Hopefully now no-one else
ed1787d
has to figure it out!
ed1787d
ed1787d
Signed-off-by: Daniel Axtens <dja@axtens.net>
ed1787d
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
ed1787d
(cherry picked from commit a6c5c52ccffd2674d43db25fb4baa9c528526aa0)
ed1787d
---
ed1787d
 include/grub/mm_private.h | 28 ++++++++++++++++++++++++++++
ed1787d
 1 file changed, 28 insertions(+)
ed1787d
ed1787d
diff --git a/include/grub/mm_private.h b/include/grub/mm_private.h
ed1787d
index c2c4cb1511..203533cc3d 100644
ed1787d
--- a/include/grub/mm_private.h
ed1787d
+++ b/include/grub/mm_private.h
ed1787d
@@ -21,15 +21,27 @@
ed1787d
 
ed1787d
 #include <grub/mm.h>
ed1787d
 
ed1787d
+/* For context, see kern/mm.c */
ed1787d
+
ed1787d
 /* Magic words.  */
ed1787d
 #define GRUB_MM_FREE_MAGIC	0x2d3c2808
ed1787d
 #define GRUB_MM_ALLOC_MAGIC	0x6db08fa4
ed1787d
 
ed1787d
+/* A header describing a block of memory - either allocated or free */
ed1787d
 typedef struct grub_mm_header
ed1787d
 {
ed1787d
+  /*
ed1787d
+   * The 'next' free block in this region's circular free list.
ed1787d
+   * Only meaningful if the block is free.
ed1787d
+   */
ed1787d
   struct grub_mm_header *next;
ed1787d
+  /* The block size, not in bytes but the number of cells of
ed1787d
+   * GRUB_MM_ALIGN bytes. Includes the header cell.
ed1787d
+   */
ed1787d
   grub_size_t size;
ed1787d
+  /* either free or alloc magic, depending on the block type. */
ed1787d
   grub_size_t magic;
ed1787d
+  /* pad to cell size: see the top of kern/mm.c. */
ed1787d
 #if GRUB_CPU_SIZEOF_VOID_P == 4
ed1787d
   char padding[4];
ed1787d
 #elif GRUB_CPU_SIZEOF_VOID_P == 8
ed1787d
@@ -48,11 +60,27 @@ typedef struct grub_mm_header
ed1787d
 
ed1787d
 #define GRUB_MM_ALIGN	(1 << GRUB_MM_ALIGN_LOG2)
ed1787d
 
ed1787d
+/* A region from which we can make allocations. */
ed1787d
 typedef struct grub_mm_region
ed1787d
 {
ed1787d
+  /* The first free block in this region. */
ed1787d
   struct grub_mm_header *first;
ed1787d
+
ed1787d
+  /*
ed1787d
+   * The next region in the linked list of regions. Regions are initially
ed1787d
+   * sorted in order of increasing size, but can grow, in which case the
ed1787d
+   * ordering may not be preserved.
ed1787d
+   */
ed1787d
   struct grub_mm_region *next;
ed1787d
+
ed1787d
+  /*
ed1787d
+   * A grub_mm_region will always be aligned to cell size. The pre-size is
ed1787d
+   * the number of bytes we were given but had to skip in order to get that
ed1787d
+   * alignment.
ed1787d
+   */
ed1787d
   grub_size_t pre_size;
ed1787d
+
ed1787d
+  /* How many bytes are in this region? (free and allocated) */
ed1787d
   grub_size_t size;
ed1787d
 }
ed1787d
 *grub_mm_region_t;