ed1787d
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
ed1787d
From: Patrick Steinhardt <ps@pks.im>
ed1787d
Date: Thu, 21 Apr 2022 15:24:20 +1000
ed1787d
Subject: [PATCH] kern/efi/mm: Extract function to add memory regions
ed1787d
ed1787d
In preparation of support for runtime-allocating additional memory
ed1787d
region, this patch extracts the function to retrieve the EFI memory
ed1787d
map and add a subset of it to GRUB's own memory regions.
ed1787d
ed1787d
Signed-off-by: Patrick Steinhardt <ps@pks.im>
ed1787d
Signed-off-by: Daniel Axtens <dja@axtens.net>
ed1787d
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
ed1787d
Tested-by: Patrick Steinhardt <ps@pks.im>
ed1787d
(cherry picked from commit 96a7ea29e3cb61b6c2302e260e8e6a6117e17fa3)
ed1787d
[rharwood: backport around our nx]
ed1787d
---
ed1787d
 grub-core/kern/efi/mm.c | 21 +++++++++++++++------
ed1787d
 1 file changed, 15 insertions(+), 6 deletions(-)
ed1787d
ed1787d
diff --git a/grub-core/kern/efi/mm.c b/grub-core/kern/efi/mm.c
ed1787d
index 782a1365a1..a1d3b51fe6 100644
ed1787d
--- a/grub-core/kern/efi/mm.c
ed1787d
+++ b/grub-core/kern/efi/mm.c
ed1787d
@@ -667,8 +667,8 @@ grub_nx_init (void)
ed1787d
     }
ed1787d
 }
ed1787d
 
ed1787d
-void
ed1787d
-grub_efi_mm_init (void)
ed1787d
+static grub_err_t
ed1787d
+grub_efi_mm_add_regions (grub_size_t required_bytes)
ed1787d
 {
ed1787d
   grub_efi_memory_descriptor_t *memory_map;
ed1787d
   grub_efi_memory_descriptor_t *memory_map_end;
ed1787d
@@ -683,7 +683,7 @@ grub_efi_mm_init (void)
ed1787d
   /* Prepare a memory region to store two memory maps.  */
ed1787d
   memory_map = grub_efi_allocate_any_pages (2 * BYTES_TO_PAGES (MEMORY_MAP_SIZE));
ed1787d
   if (! memory_map)
ed1787d
-    grub_fatal ("cannot allocate memory");
ed1787d
+    return grub_error (GRUB_ERR_OUT_OF_MEMORY, "cannot allocate memory for memory map");
ed1787d
 
ed1787d
   /* Obtain descriptors for available memory.  */
ed1787d
   map_size = MEMORY_MAP_SIZE;
ed1787d
@@ -701,14 +701,14 @@ grub_efi_mm_init (void)
ed1787d
 
ed1787d
       memory_map = grub_efi_allocate_any_pages (2 * BYTES_TO_PAGES (map_size));
ed1787d
       if (! memory_map)
ed1787d
-	grub_fatal ("cannot allocate memory");
ed1787d
+	return grub_error (GRUB_ERR_OUT_OF_MEMORY, "cannot allocate memory for new memory map");
ed1787d
 
ed1787d
       mm_status = grub_efi_get_memory_map (&map_size, memory_map, 0,
ed1787d
 					   &desc_size, 0);
ed1787d
     }
ed1787d
 
ed1787d
   if (mm_status < 0)
ed1787d
-    grub_fatal ("cannot get memory map");
ed1787d
+    return grub_error (GRUB_ERR_OUT_OF_MEMORY, "error fetching memory map from EFI");
ed1787d
 
ed1787d
   memory_map_end = NEXT_MEMORY_DESCRIPTOR (memory_map, map_size);
ed1787d
 
ed1787d
@@ -723,7 +723,7 @@ grub_efi_mm_init (void)
ed1787d
 
ed1787d
   /* Allocate memory regions for GRUB's memory management.  */
ed1787d
   add_memory_regions (filtered_memory_map, desc_size,
ed1787d
-		      filtered_memory_map_end, BYTES_TO_PAGES (DEFAULT_HEAP_SIZE));
ed1787d
+		      filtered_memory_map_end, BYTES_TO_PAGES (required_bytes));
ed1787d
 
ed1787d
 #if 0
ed1787d
   /* For debug.  */
ed1787d
@@ -741,6 +741,15 @@ grub_efi_mm_init (void)
ed1787d
   /* Release the memory maps.  */
ed1787d
   grub_efi_free_pages ((grub_addr_t) memory_map,
ed1787d
 		       2 * BYTES_TO_PAGES (MEMORY_MAP_SIZE));
ed1787d
+
ed1787d
+  return GRUB_ERR_NONE;
ed1787d
+}
ed1787d
+
ed1787d
+void
ed1787d
+grub_efi_mm_init (void)
ed1787d
+{
ed1787d
+  if (grub_efi_mm_add_regions (DEFAULT_HEAP_SIZE) != GRUB_ERR_NONE)
ed1787d
+    grub_fatal ("%s", grub_errmsg);
ed1787d
 }
ed1787d
 
ed1787d
 #if defined (__aarch64__) || defined (__arm__) || defined (__riscv)