#135 Properly using macros where they were missing
Merged 2 years ago by jvanek. Opened 2 years ago by jvanek.
Unknown source tinyFixes  into  rawhide

file modified
+5 -3
@@ -394,8 +394,8 @@

  %global jdkimage                jdk

  %global static_libs_image       static-libs

  # output dir stub

- %define buildoutputdir() %{expand:build/jdk11.build%{?1}}

- %define installoutputdir() %{expand:install/jdk11.install%{?1}}

+ %define buildoutputdir() %{expand:build/jdk%{featurever}.build%{?1}}

+ %define installoutputdir() %{expand:install/jdk%{featurever}.install%{?1}}

  # we can copy the javadoc to not arched dir, or make it not noarch

  %define uniquejavadocdir()    %{expand:%{fullversion}.%{_arch}%{?1}}

  # main id and dir of this jdk
@@ -410,7 +410,7 @@

  %if %is_system_jdk

  %global __provides_exclude ^(%{_privatelibs})$

  %global __requires_exclude ^(%{_privatelibs})$

- # Never generate lib-style provides/requires for slowdebug packages

+ # Never generate lib-style provides/requires for any debug packages

  %global __provides_exclude_from ^.*/%{uniquesuffix -- %{debug_suffix_unquoted}}/.*$

  %global __requires_exclude_from ^.*/%{uniquesuffix -- %{debug_suffix_unquoted}}/.*$

  %global __provides_exclude_from ^.*/%{uniquesuffix -- %{fastdebug_suffix_unquoted}}/.*$
@@ -1598,7 +1598,9 @@

  

  %description javadoc

  The %{origin_nice} %{featurever} API documentation.

+ %endif

  

+ %if %{include_normal_build}

  %package javadoc-zip

  Summary: %{origin_nice} %{featurever} API documentation compressed in a single archive

  %if 0%{?rhel} <= 8

no initial comment

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

Note that scratch was ok, except (again) timeout on ppc64le

It's not clear to me what the purpose of these changes is. They don't really match the PR description.

  • The featurever change seems to be a backport from java-latest-openjdk, which looks ok
  • The improved conditional looks correct, but there are more cases than that one, which I think warrants its own changeset for easy porting to other repos.
  • The closing of the %{include_normal_build} conditional only to immediately reopen it is completely redundant.

It's not clear to me what the purpose of these changes is. They don't really match the PR description.

  • The featurever change seems to be a backport from java-latest-openjdk, which looks ok

ok. Will commit as separate changeset.

  • The improved conditional looks correct, but there are more cases than that one, which I think warrants its own changeset for easy porting to other repos.

I agree, but I had not noticed more of them. I wll happily look again and move as single changeset. Do you have some clue where you had seen others?

  • The closing of the %{include_normal_build} conditional only to immediately reopen it is completely redundant.

Everyu subpkg have its own if/endif, only those two are missing, and only in java-latest-opendjk. So it really so fixing a nasty non-alignment

rebased onto a838289

2 years ago

Pull-Request has been merged by jvanek

2 years ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

It's not clear to me what the purpose of these changes is. They don't really match the PR description.

  • The featurever change seems to be a backport from java-latest-openjdk, which looks ok

ok. Will commit as separate changeset.

Why has this been merged when it was still under review?

  • The improved conditional looks correct, but there are more cases than that one, which I think warrants its own changeset for easy porting to other repos.

I agree, but I had not noticed more of them. I wll happily look again and move as single changeset. Do you have some clue where you had seen others?

See https://src.fedoraproject.org/rpms/java-latest-openjdk/pull-request/86

  • The closing of the %{include_normal_build} conditional only to immediately reopen it is completely redundant.

Everyu subpkg have its own if/endif, only those two are missing, and only in java-latest-opendjk. So it really so fixing a nasty non-alignment

Every other subpackage has debug variants, the zip ones don't. This is a remnant of when we had those variants.

I'll be reverting this. java-latest-openjdk's version is correct.

Metadata