|
 |
978e9d5 |
From: Dan Carpenter <dan.carpenter@oracle.com>
|
|
|
978e9d5 |
Date: 2016-09-15 13:44:56
|
|
|
978e9d5 |
Subject: [patch v2] arcmsr: buffer overflow in arcmsr_iop_message_xfer()
|
|
|
978e9d5 |
|
|
|
978e9d5 |
We need to put an upper bound on "user_len" so the memcpy() doesn't
|
|
|
978e9d5 |
overflow.
|
|
|
978e9d5 |
|
|
|
978e9d5 |
Reported-by: Marco Grassi <marco.gra@gmail.com>
|
|
|
978e9d5 |
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
|
|
|
978e9d5 |
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
|
|
|
978e9d5 |
|
|
|
978e9d5 |
diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
|
|
|
978e9d5 |
index 7640498..110eca9 100644
|
|
|
978e9d5 |
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
|
|
|
978e9d5 |
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
|
|
|
978e9d5 |
@@ -2388,7 +2388,8 @@ static int arcmsr_iop_message_xfer(struct AdapterControlBlock *acb,
|
|
|
978e9d5 |
}
|
|
|
978e9d5 |
case ARCMSR_MESSAGE_WRITE_WQBUFFER: {
|
|
|
978e9d5 |
unsigned char *ver_addr;
|
|
|
978e9d5 |
- int32_t user_len, cnt2end;
|
|
|
978e9d5 |
+ uint32_t user_len;
|
|
|
978e9d5 |
+ int32_t cnt2end;
|
|
|
978e9d5 |
uint8_t *pQbuffer, *ptmpuserbuffer;
|
|
|
978e9d5 |
ver_addr = kmalloc(ARCMSR_API_DATA_BUFLEN, GFP_ATOMIC);
|
|
|
978e9d5 |
if (!ver_addr) {
|
|
|
978e9d5 |
@@ -2397,6 +2398,11 @@ static int arcmsr_iop_message_xfer(struct AdapterControlBlock *acb,
|
|
|
978e9d5 |
}
|
|
|
978e9d5 |
ptmpuserbuffer = ver_addr;
|
|
|
978e9d5 |
user_len = pcmdmessagefld->cmdmessage.Length;
|
|
|
978e9d5 |
+ if (user_len > ARCMSR_API_DATA_BUFLEN) {
|
|
|
978e9d5 |
+ retvalue = ARCMSR_MESSAGE_FAIL;
|
|
|
978e9d5 |
+ kfree(ver_addr);
|
|
|
978e9d5 |
+ goto message_out;
|
|
|
978e9d5 |
+ }
|
|
|
978e9d5 |
memcpy(ptmpuserbuffer,
|
|
|
978e9d5 |
pcmdmessagefld->messagedatabuffer, user_len);
|
|
|
978e9d5 |
spin_lock_irqsave(&acb->wqbuffer_lock, flags);
|
|
|
978e9d5 |
--
|
|
|
978e9d5 |
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
|
|
|
978e9d5 |
the body of a message to majordomo@vger.kernel.org
|
|
|
978e9d5 |
More majordomo info at http://vger.kernel.org/majordomo-info.html
|