|
 |
10ef192 |
Path: news.gmane.org!not-for-mail
|
|
|
10ef192 |
From: Yuchung Cheng <ycheng@google.com>
|
|
|
10ef192 |
Newsgroups: gmane.linux.network
|
|
|
10ef192 |
Subject: [PATCH net] tcp: fix incorrect ca_state in tail loss probe
|
|
|
10ef192 |
Date: Sat, 12 Oct 2013 10:16:27 -0700
|
|
|
10ef192 |
Lines: 34
|
|
|
10ef192 |
Approved: news@gmane.org
|
|
|
10ef192 |
Message-ID: <1381598187-9681-1-git-send-email-ycheng@google.com>
|
|
|
10ef192 |
NNTP-Posting-Host: plane.gmane.org
|
|
|
10ef192 |
X-Trace: ger.gmane.org 1381598242 29686 80.91.229.3 (12 Oct 2013 17:17:22 GMT)
|
|
|
10ef192 |
X-Complaints-To: usenet@ger.gmane.org
|
|
|
10ef192 |
NNTP-Posting-Date: Sat, 12 Oct 2013 17:17:22 +0000 (UTC)
|
|
|
10ef192 |
Cc: netdev@vger.kernel.org, michael@sterretts.net,
|
|
|
10ef192 |
jwboyer@fedoraproject.org, sesse@google.com, dormando@rydia.net,
|
|
|
10ef192 |
Yuchung Cheng <ycheng@google.com>
|
|
|
10ef192 |
To: davem@davemloft.net, ncardwell@google.com, nanditad@google.com
|
|
|
10ef192 |
Original-X-From: netdev-owner@vger.kernel.org Sat Oct 12 19:17:23 2013
|
|
|
10ef192 |
Return-path: <netdev-owner@vger.kernel.org>
|
|
|
10ef192 |
Envelope-to: linux-netdev-2@plane.gmane.org
|
|
|
10ef192 |
Original-Received: from vger.kernel.org ([209.132.180.67])
|
|
|
10ef192 |
by plane.gmane.org with esmtp (Exim 4.69)
|
|
|
10ef192 |
(envelope-from <netdev-owner@vger.kernel.org>)
|
|
|
10ef192 |
id 1VV2od-0004tp-02
|
|
|
10ef192 |
for linux-netdev-2@plane.gmane.org; Sat, 12 Oct 2013 19:17:23 +0200
|
|
|
10ef192 |
Original-Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
|
|
|
10ef192 |
id S1753183Ab3JLRRU (ORCPT <rfc822;linux-netdev-2@m.gmane.org>);
|
|
|
10ef192 |
Sat, 12 Oct 2013 13:17:20 -0400
|
|
|
10ef192 |
Original-Received: from mail-pb0-f74.google.com ([209.85.160.74]:35839 "EHLO
|
|
|
10ef192 |
mail-pb0-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
|
|
|
10ef192 |
with ESMTP id S1752493Ab3JLRRS (ORCPT
|
|
|
10ef192 |
<rfc822;netdev@vger.kernel.org>); Sat, 12 Oct 2013 13:17:18 -0400
|
|
|
10ef192 |
Original-Received: by mail-pb0-f74.google.com with SMTP id rq2so543459pbb.1
|
|
|
10ef192 |
for <netdev@vger.kernel.org>; Sat, 12 Oct 2013 10:17:18 -0700 (PDT)
|
|
|
10ef192 |
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
|
|
|
10ef192 |
d=google.com; s=20120113;
|
|
|
10ef192 |
h=from:to:cc:subject:date:message-id;
|
|
|
10ef192 |
bh=YSBIMZEgVuqyP2cau1199a1sz5d28JA7LPPsF6w9FYQ=;
|
|
|
10ef192 |
b=cCkXgePT7f0kRy+VBGvs3DZSLhVn0z7O74B7OHYpdZkQBznhNZ2b6ZGbkDqaKJXyLT
|
|
|
10ef192 |
GEsq/JXCgtwpC7aGSz9dPdAZU6kondKOAmfhh54u6f2+ymcZJ4zHpoA6mWuKJ4zlTF2w
|
|
|
10ef192 |
6tRhnT+/N5RkfIfYD/mcDx97X41kRT3NKJ6bsCoiNJIO2+6j8SrOi8C27InOkdIRY/AT
|
|
|
10ef192 |
I1uu2bvai1CfrC5yQ6UfpKUg2jioFDOi7i5nSEon+JnWeJavHpO01JMHuar7ZeGnAKJg
|
|
|
10ef192 |
kVLwyiRujU9Fz0CKIMPZihAngQu/0OgqORQIjygeqz+GPgtTxDGQP7IUNR/d+JOPVUse
|
|
|
10ef192 |
XlSA==
|
|
|
10ef192 |
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
|
|
|
10ef192 |
d=1e100.net; s=20130820;
|
|
|
10ef192 |
h=x-gm-message-state:from:to:cc:subject:date:message-id;
|
|
|
10ef192 |
bh=YSBIMZEgVuqyP2cau1199a1sz5d28JA7LPPsF6w9FYQ=;
|
|
|
10ef192 |
b=d95i7RXY0ff5vnWvrGqxWfSvvAE8SC6YAaBn3ZqbARIZm5GgynIAB/WYnrIOqpqGV6
|
|
|
10ef192 |
56jVM40bfzLrols1UZzyJWqPIgxee1zPrESh+WrSsDP2tTdYKl/zk13lbt/u7nOn9o3u
|
|
|
10ef192 |
HrAo2aY4DtV3P0ABEq1lKdazmmPACTc6256QQ2nxtHs5n7s7P1ERkpX7NGNqNf1zDBSv
|
|
|
10ef192 |
60xeoswRpMkh0G5ZUgpPYsIbXws9F64n5ytq34O2UDZPv5oPEd8I7P34HpqWkNsLoEBs
|
|
|
10ef192 |
XXTxs1SLc8TI3vdduhaQ+rmEvcE5vTaqjVCQAT2mMKTJJ9xIFueF5zExfI892PHAcJQ8
|
|
|
10ef192 |
jiaw==
|
|
|
10ef192 |
X-Gm-Message-State: ALoCoQkeL+3MY64KlpZKI1BuYMU+yTQcYF1C+U5u+kPpqROoekUMzIaH45qERBARAi/0vgJ5YM1Cwm+43d66vZMn/WdHPurbMHfFn3PYqeZSAzOEeuSA2jGTSZUkpuH8YwFqiNhABtj93ahsBXrA6POrXb531UvuahU+rnFLTGNLxVHv/08PW3l5PbN8UaTNpUI1qcf6O6MarFcB+fZLYPb339v4EIrLxg==
|
|
|
10ef192 |
X-Received: by 10.66.5.226 with SMTP id v2mr8825633pav.22.1381598238410;
|
|
|
10ef192 |
Sat, 12 Oct 2013 10:17:18 -0700 (PDT)
|
|
|
10ef192 |
Original-Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93])
|
|
|
10ef192 |
by gmr-mx.google.com with ESMTPS id a24si3247317yhl.1.1969.12.31.16.00.00
|
|
|
10ef192 |
(version=TLSv1.1 cipher=AES128-SHA bits=128/128);
|
|
|
10ef192 |
Sat, 12 Oct 2013 10:17:18 -0700 (PDT)
|
|
|
10ef192 |
Original-Received: from blast2.mtv.corp.google.com (blast2.mtv.corp.google.com [172.17.132.164])
|
|
|
10ef192 |
by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 2F2B45A41A0;
|
|
|
10ef192 |
Sat, 12 Oct 2013 10:17:18 -0700 (PDT)
|
|
|
10ef192 |
Original-Received: by blast2.mtv.corp.google.com (Postfix, from userid 5463)
|
|
|
10ef192 |
id C6A85220C26; Sat, 12 Oct 2013 10:17:17 -0700 (PDT)
|
|
|
10ef192 |
X-Mailer: git-send-email 1.8.4
|
|
|
10ef192 |
Original-Sender: netdev-owner@vger.kernel.org
|
|
|
10ef192 |
Precedence: bulk
|
|
|
10ef192 |
List-ID: <netdev.vger.kernel.org>
|
|
|
10ef192 |
X-Mailing-List: netdev@vger.kernel.org
|
|
|
10ef192 |
Xref: news.gmane.org gmane.linux.network:286793
|
|
|
10ef192 |
Archived-At: <http://permalink.gmane.org/gmane.linux.network/286793>
|
|
|
10ef192 |
|
|
|
10ef192 |
On receiving an ACK that covers the loss probe sequence, TLP
|
|
|
10ef192 |
immediately sets the congestion state to Open, even though some packets
|
|
|
10ef192 |
are not recovered and retransmisssion are on the way. The later ACks
|
|
|
10ef192 |
may trigger a WARN_ON check in step D of tcp_fastretrans_alert(), e.g.,
|
|
|
10ef192 |
https://bugzilla.redhat.com/show_bug.cgi?id=989251
|
|
|
10ef192 |
|
|
|
10ef192 |
The fix is to follow the similar procedure in recovery by calling
|
|
|
10ef192 |
tcp_try_keep_open(). The sender switches to Open state if no packets
|
|
|
10ef192 |
are retransmissted. Otherwise it goes to Disorder and let subsequent
|
|
|
10ef192 |
ACKs move the state to Recovery or Open.
|
|
|
10ef192 |
|
|
|
10ef192 |
Reported-By: Michael Sterrett <michael@sterretts.net>
|
|
|
10ef192 |
Tested-By: Dormando <dormando@rydia.net>
|
|
|
10ef192 |
Signed-off-by: Yuchung Cheng <ycheng@google.com>
|
|
|
10ef192 |
---
|
|
|
10ef192 |
net/ipv4/tcp_input.c | 2 +-
|
|
|
10ef192 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
10ef192 |
|
|
|
10ef192 |
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
|
|
|
10ef192 |
index 113dc5f..53974c7 100644
|
|
|
10ef192 |
--- a/net/ipv4/tcp_input.c
|
|
|
10ef192 |
+++ b/net/ipv4/tcp_input.c
|
|
|
10ef192 |
@@ -3291,7 +3291,7 @@ static void tcp_process_tlp_ack(struct sock *sk, u32 ack, int flag)
|
|
|
10ef192 |
tcp_init_cwnd_reduction(sk, true);
|
|
|
10ef192 |
tcp_set_ca_state(sk, TCP_CA_CWR);
|
|
|
10ef192 |
tcp_end_cwnd_reduction(sk);
|
|
|
10ef192 |
- tcp_set_ca_state(sk, TCP_CA_Open);
|
|
|
10ef192 |
+ tcp_try_keep_open(sk);
|
|
|
10ef192 |
NET_INC_STATS_BH(sock_net(sk),
|
|
|
10ef192 |
LINUX_MIB_TCPLOSSPROBERECOVERY);
|
|
|
10ef192 |
}
|
|
|
10ef192 |
--
|
|
|
10ef192 |
1.8.4
|
|
|
10ef192 |
|