PR#1: Update to 4.4.0 - rpms/krita - src.fedoraproject.org

rpms / krita

#1 Update to 4.4.0

Merged 3 years ago by rdieter. Opened 3 years ago by loise.

Unknown source master into master

4.4.0

Marie Loise Nolden • 3 years ago

d8a110f

Update .gitignore

Marie Loise Nolden • 3 years ago

6fddb90

4.4.0

Marie Loise Nolden • 3 years ago

29290d9

.gitignore

file modified

		`@@ -17,3 +17,4 @@`
		`/krita-4.2.8.2.tar.xz`
		`/krita-4.2.9.tar.xz`
		`/krita-4.3.0.tar.xz`
		`+ /krita-4.4.0.tar.xz`

krita.spec

file modified

+6 -2

		`@@ -3,8 +3,8 @@`
		`%global krita_python 1`

		`Name: krita`
		`- Version: 4.3.0`
		`- Release: 3%{?dist}`
		`+ Version: 4.4.0`
		`+ Release: 1%{?dist}`
		`Summary: Krita is a sketching and painting program`
		`License: GPLv2+`
		`URL: http://krita.org`
		`@@ -114,6 +114,7 @@`
		`%license COPYING*`
		`%config(noreplace) %{_sysconfdir}/xdg/kritarc`
		`%{_kf5_bindir}/krita`
		`+ %{_kf5_bindir}/krita_version`
		`%{_kf5_libdir}/kritaplugins/`
		`%{_kf5_metainfodir}/org.kde.krita.appdata.xml`
		`%{_kf5_datadir}/applications/org.kde.krita.desktop`
		`@@ -139,6 +140,9 @@`


		`%changelog`
		`+ * Wed Oct 28 2020 Marie Loise Nolden <loise@kde.org> - 4.4.0-1`
		`+ - 4.4.0`
		`+`
		`* Wed Oct 28 2020 Jeff Law <law@redhat.com> - 4.3.0-3`
		`- Fix missing #includes for gcc-11`

sources

file modified

+1 -1

		`@@ -1,1 +1,1 @@`
		`- SHA512 (krita-4.3.0.tar.xz) = 5633a6ccacc140b119082f14fe792b1219b8065304fccc55a84a2373a46cb036ad40f718beb8719e1f664e35d679b18e86f5f3db8685166a187d8cf3a77722f4`
		`+ SHA512 (krita-4.4.0.tar.xz) = bfb84279c04fa0c7ec90daa5fc2e185019210e52ac79a655639387ed28e0904659e165379191b29f5261ebadd5c0d062f95435769c2ab42742d7853a5b0d244c`

no initial comment

rdieter commented 3 years ago

Did you test if this newer version successfully builds or not? I was under the impression krita grew a new dependency that isn't packaged yet, wasn't sure if it was required or optional.

Guessing yes, but would like confirmation before merging.

Edited 3 years ago by rdieter

loise commented 3 years ago

Yes, I even ran it on centos 8...

https://download.copr.fedorainfracloud.org/results/loise/KentOS-8.2.2004-Updates/epel-8-x86_64/01726176-krita/

That's how I found the missing krita_version binary and built the rpms after compiling twice and installing.

However, you're right, I heard that too and had a look through the logs:

https://download.copr.fedorainfracloud.org/results/loise/KentOS-8.2.2004-Updates/epel-8-x86_64/01726176-krita/builder-live.log.gz

CMake Warning at CMakeLists.txt:594 (find_package):
By not providing "FindSeExpr2.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "SeExpr2", but
CMake did not find one.

Could not find a package configuration file provided by "SeExpr2" with any
of the following names:

SeExpr2Config.cmake
seexpr2-config.cmake

Add the installation prefix of "SeExpr2" to CMAKE_PREFIX_PATH or set
"SeExpr2_DIR" to a directory containing one of the above files. If
"SeExpr2" provides a separate development package or SDK, be sure it has
been installed.

which is what was named in the mailing lists. I guess we'd handle that in two steps, first upgrade to 4.4.0 as-is (like with my pull request) and then take care to add seexpr2 as a package to fedora. Then utilizing this in a further revision.

But that's just how I'd do it.