PR#8: Fix FTBFS-Remove libpq-devel requirement, it conflicts with postgresql-server-devel dependencies - rpms/libpqxx

rpms / libpqxx

#8 Fix FTBFS-Remove libpq-devel requirement, it conflicts with postgresql-server-devel dependencies

Closed 2 years ago by mkrupcale. Opened 2 years ago by fjanus.

rpms/ fjanus/libpqxx rawhide into rawhide

Fix FTBFS-Remove libpq-devel requirement, it conflicts with postgresql-server-devel dependencies

Filip Januš • 2 years ago

7ea82bd

libpqxx.spec

file modified

+5 -2

		`@@ -5,7 +5,7 @@`
		`Summary: C++ client API for PostgreSQL`
		`Epoch: 1`
		`Version: 7.3.1`
		`- Release: 5%{?dist}`
		`+ Release: 6%{?dist}`

		`%global forgeurl https://github.com/jtv/%{name}/`
		`%global tag %{version}`
		`@@ -19,7 +19,6 @@`
		`BuildRequires: ninja-build`
		`BuildRequires: cmake`
		`BuildRequires: pkgconfig`
		`- BuildRequires: libpq-devel`
		`BuildRequires: postgresql-server-devel`
		`%if %{with check}`
		`BuildRequires: postgresql-test-rpm-macros`
		`@@ -103,6 +102,10 @@`
		`%endif`

		`%changelog`
		`+ * Tue Jul 27 2021 Filip Januš <fjanus@redhat.com> - 1:7.3.1-6`
		`+ - Remove libpq-devel requirement, it conflicts with postgresql-server-devel`
		`+ dependencies`
		`+`
		`* Thu Jul 22 2021 Fedora Release Engineering <releng@fedoraproject.org> - 1:7.3.1-5`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild`

no initial comment

mkrupcale commented 2 years ago

It looks like the CI failed due to a networking error, so I guess that can be ignored.

Regarding the change, I'm not actually sure libpqxx requires postgresql-server-devel instead of just the client library libpq-devel. So per [1], perhaps the change should be the reverse, but I'll have to do some testing (probably this weekend, maybe sometime this week).

[1] https://fedoraproject.org/wiki/Changes/PostgreSQL_13#Dependencies

fjanus commented 2 years ago

Definitely is preferred to use libpq, but I am not sure what is for libpqxx necessary. If need both postgresql-server-devel and libpq-devel then there is only one option(remove libpq-devel) and use private verison of libpq-devel(postgresql-private-devel). If postgresql-server-devel is not necessary please use libpq-devel.

mkrupcale commented 2 years ago

Fixed [1-3] by dropping BuildRequires on postgresql-server-devel since libpq-devel seems to be enough.

[1] https://src.fedoraproject.org/rpms/libpqxx/c/a9fc2a6b69ebc10ae57b8b764bf8c3d0e3814679?branch=rawhide
[2] https://koji.fedoraproject.org/koji/buildinfo?buildID=1811917
[3] https://bodhi.fedoraproject.org/updates/FEDORA-2021-01654435d8