#1 Stop using gcc specific binutils
Merged 3 years ago by frantisekz. Opened 3 years ago by tstellar.
rpms/ tstellar/mozjs68 drop-gcc-binutils  into  master

file modified
+5 -2
@@ -28,7 +28,7 @@ 

  

  Name:           mozjs%{major}

  Version:        68.10.0

- Release:        2%{?dist}

+ Release:        3%{?dist}

  Summary:        SpiderMonkey JavaScript library

  

  License:        MPLv2.0 and MPLv1.1 and BSD and GPLv2+ and GPLv3+ and LGPLv2+ and AFL and ASL 2.0
@@ -143,7 +143,7 @@ 

  export CC=gcc

  export CXX=g++

  

- %if 0%{?build_with_lto}

+ %if 0%{?build_with_lto} && 0%{?fedora} < 33

  export AR=%{_bindir}/gcc-ar

  export RANLIB=%{_bindir}/gcc-ranlib

  export NM=%{_bindir}/gcc-nm
@@ -261,6 +261,9 @@ 

  %{_includedir}/mozjs-%{major}/

  

  %changelog

+ * Thu Jul 30 2020 Tom Stellard <tstellar@redhat.com> - 68.10.0-3

+ - Stop using gcc specific binutils

+ 

  * Tue Jul 28 2020 Fedora Release Engineering <releng@fedoraproject.org> - 68.10.0-2

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild

  

gcc-ar, gcc-ranlib, and gcc-nm are wrappers around the standard version of
these tools that manually load the gcc lto plugin. As of
gcc-10.1.1-2.fc33, gcc installs an lto plugin symlink to
%%{_libdir}/bfd-plugins, so ar, ranlib, nm, and other bintuils are able
to automatically find and load it when processing LTO binaires.

This change in gcc has not been backported to f32. Should I add an %if 0%{?fedora} < 33 around the code that was removed or should we just wait until f32 has this change.

rebased onto 26bd289

3 years ago

I've added a conditional to only use the standard tools on >= f33.

Pull-Request has been merged by frantisekz

3 years ago