PR#5: RPM provide python3dist(ninja) - rpms/ninja-build

rpms / ninja-build

#5 RPM provide python3dist(ninja)

Closed 3 years ago by ignatenkobrain. Opened 3 years ago by mavit.

rpms/ mavit/ninja-build python3dist into master

Peter Oliver • 3 years ago

6b2a780

ninja-build.spec

file modified

+5 -1

		`@@ -4,7 +4,7 @@`

		`Name: ninja-build`
		`Version: 1.10.1`
		`- Release: 2%{?dist}`
		`+ Release: 3%{?dist}`
		`Summary: Small build system with a focus on speed`
		`License: ASL 2.0`
		`URL: https://ninja-build.org/`
		`@@ -16,6 +16,7 @@`
		`BuildRequires: python2-devel`
		`%else`
		`BuildRequires: python3-devel`
		`+ Provides: %{py3_dist ninja} = %{version}-%{release}`
		`%endif`
		`%if %{without bootstrap}`
		`BuildRequires: asciidoc`
		`@@ -107,6 +108,9 @@`
		`%{rpmmacrodir}/macros.ninja`

		`%changelog`
		`+ * Thu Aug 20 2020 Peter Oliver <rpm@mavit.org.uk> - 1.10.1-3`
		`+ - RPM provide python3dist(ninja).`
		`+`
		`* Wed Aug 19 2020 Björn Esser <besser82@fedoraproject.org> - 1.10.1-2`
		`- Add ninja_syntax.py`

mavit commented 3 years ago

Python packages typically have a Provdes of this form.

ignatenkobrain commented 3 years ago

Yes, but ninja is not a Python package.

mavit commented 3 years ago

It delivers a Python module. Doesn't that count?

ignatenkobrain commented 3 years ago

❯ rpm -ql ninja-build | grep python3
/usr/lib/python3.9/site-packages/__pycache__/ninja_syntax.cpython-39.opt-1.pyc
/usr/lib/python3.9/site-packages/__pycache__/ninja_syntax.cpython-39.pyc
/usr/lib/python3.9/site-packages/ninja_syntax.py

We should probably even drop it instead. Anyhow, adding this provide is completely useless.