rpms / pam

Clone
Source Code
GIT

#14 Return PAM_AUTHINFO_UNAVAIL from pam_fprintd.so
Merged 3 years ago by ipedrosa. Opened 3 years ago by benzea.
rpms/ benzea/pam rawhide  into  rawhide

file modified
+1 -1 
@@ -2,7 +2,7 @@ 
 

  # This file is auto-generated.
 

  # User changes will be destroyed the next time authselect is run.
 

  auth        required      pam_env.so
 

- auth        sufficient    pam_fprintd.so
 

+ auth        [success=done default=bad] pam_fprintd.so
 

  auth        required      pam_deny.so
 

  

  account     required      pam_unix.so

GDM/gnome-shell expects being able to tell apart various failure modes
from the pam_fprintd.so. However, using "sufficient" means that the
generic error code from pam_deny.so will be returned.

Use default=bad, to ensure that the failing error code from
pam_fprintd.so is correctly exposed to GDM.

NOTE: This is an important fix for F34 and should also be applied there.

I can also update the PR with changelog and create a separate F34 PR.

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

It looks good to me, thank you!

I'll merge the PR but I also need to include another change before building the changes for rawhide. I hope to have everything ready this afternoon.

By the way, I'll also include it in f34 once the change is stable in rawhide.

Pull-Request has been merged by ipedrosa
3 years ago
Metadata
None
No Tags
Changes Summary 1
+1 -1
file changed
fingerprint-auth.pamd
Powered by Pagure 5.14.1
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.