PR#5: update test.yml - rpms/parted - src.fedoraproject.org

rpms / parted

#5 update test.yml

Merged 3 years ago by bcl. Opened 3 years ago by bgoncalv.

rpms/ bgoncalv/parted fix-tests into master

update test.yml

Bruno Goncalves • 3 years ago

c4782e2

tests/tests.yml

file modified

+10 -29

		`@@ -1,33 +1,14 @@`
		`---`
		`- # Run parted's tests by rebuilding the rpm and running the %check section`
		`- hosts: localhost`
		`- vars:`
		`- package: parted`
		`- tenv_workdir: "/tmp/workdir"`
		`tags:`
		`- - classic`
		`- tasks:`
		`- - name: Copy the spec file over to the workdir`
		`- copy:`
		`- src: "{{ playbook_dir }}/../{{ package }}.spec"`
		`- dest: "{{ tenv_workdir }}/"`
		`-`
		`- - hosts: localhost`
		`- vars:`
		`- tenv_workdir: "/tmp/workdir"`
		`+ - classic`
		`roles:`
		`- - role: standard-test-source`
		`- tags:`
		`- - always`
		`-`
		`- - role: standard-test-basic`
		`- tags:`
		`- - classic`
		`-`
		`- required_packages:`
		`- - dnf`
		`- - rpm-build`
		`-`
		`- tests:`
		`- - simple:`
		`- run: "./run_tests.sh {{ tenv_workdir }}"`
		`+ - role: standard-test-source`
		`+ required_packages:`
		`+ - dnf`
		`+ - rpm-build`
		`+ - git`
		`+ - role: standard-test-basic`
		`+ tests:`
		`+ - simple:`
		`+ run: "./run_tests.sh {{ tenv_workdir }}"`

bgoncalv commented 3 years ago

make sure git is installed in the VM before extracting the source

bcl commented 3 years ago

Ah, much simpler now. But my big question is why this has to be explicitly included. git is in BuildRequires so the system should know how to set it up instead of manually listing git in the package list.

bgoncalv commented 3 years ago

There was some discussion some time ago and it seems it was decided the role would not install all packages from build requires by default. It has been done some changes in the role since then, so if you open an issue on https://pagure.io/standard-test-roles/issues it might get approved, but I can't promise it though.

bcl commented 3 years ago

Thanks for the explanation.