rpms / php

Clone
Source Code
GIT

#3 Build require pkgconfig(libzip)
Closed 4 years ago by remi. Opened 4 years ago by carlwgeorge.
rpms/ carlwgeorge/php pkgconfig-libzip  into  master

file modified
+1 -1 
@@ -139,7 +139,7 @@ 
 

  BuildRequires: gcc-c++
 

  BuildRequires: libtool
 

  BuildRequires: libtool-ltdl-devel
 

- BuildRequires: libzip-devel >= 0.11
 

+ BuildRequires: pkgconfig(libzip) >= 0.11
 

  BuildRequires: systemtap-sdt-devel
 

  # used for tests
 

  BuildRequires: %{_bindir}/ps

Per package guidelines, packages that use pkgconfig to build against a library should express their build requirement as such.

https://github.com/php/php-src/blob/php-7.4.1/ext/zip/config.m4#L7
https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/

Pull-Request has been closed by remi
4 years ago

I'm confused, why aren't we specifying pkgconfig(libzip) as a build requirement? Is it no longer necessary?

zip extension is a separate package for years (php-pecl-zip)

Ah yes, thanks for clarifying.
Changes Summary 1
+1 -1
file changed
php.spec
Powered by Pagure 5.14.1
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.