#412 Communicate loudly that this does not work with old RPM
Merged 8 months ago by churchyard. Opened 8 months ago by churchyard.
rpms/ churchyard/pyproject-rpm-macros rpm4.15  into  rawhide

file modified
+10
@@ -77,6 +77,12 @@ 

  Requires:       /usr/bin/find

  Requires:       /usr/bin/sed

  

+ # This package requires the %%generate_buildrequires functionality.

+ # It has been introduced in RPM 4.15 (4.14.90 is the alpha of 4.15).

+ # What we need is rpmlib(DynamicBuildRequires), but that is impossible to (Build)Require.

+ Requires:       (rpm-build >= 4.14.90 if rpm-build)

+ BuildRequires:  rpm-build >= 4.14.90

+ 

  %description

  These macros allow projects that follow the Python packaging specifications

  to be packaged as RPMs.
@@ -95,6 +101,7 @@ 

  %package -n pyproject-srpm-macros

  Summary:        Minimal implementation of %%pyproject_buildrequires

  Requires:       (pyproject-rpm-macros = %{?epoch:%{epoch}:}%{version}-%{release} if pyproject-rpm-macros)

+ Requires:       (rpm-build >= 4.14.90 if rpm-build)

  

  %description -n pyproject-srpm-macros

  This package contains a minimal implementation of %%pyproject_buildrequires.
@@ -109,6 +116,9 @@ 

  %setup -c -T

  cp -p %{sources} .

  

+ %generate_buildrequires

+ # nothing to do, this is here just to assert we have that functionality

+ 

  %build

  # nothing to do, sources are not buildable

  

I have seen several folks building this package in a RHEL 8 environment.
This won't prevent them doing so, but at least they will be forced to make changes,
acknowledging the fact that what they are doing has consequences.

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/e375c763842e4196a0ae0acdab7050df

I'm ambivalent about the change itself, but the code is fine and justified with a commit message and a specfile comment.

  • [x] PR solves the issue it claims to address (updates the package, solves a bug, etc.)
  • [x] Resulting RPM package is installable on the destination Fedora release
  • [x] No dependent RPM packages will stop being installable when the PR is merged and built
  • [x] PR is tested sufficiently and the test results are OK (green CI, impact check issues addressed)
  • [x] PR is open against all relevant Fedora releases
  • [-] (If PR is open against more Fedora releases) branches don't diverge unnecessarily
  • [-] (If PR is open against older Fedora releases) PR doesn't contain backwards incompatible changes
  • [x] Each commit's scope is sane (there are no irrelevant changes combined together)
  • [x] Each commit message is relevant
  • [-] (If it's linked), the right (problem, product) BZ ticket is referenced
  • [-] (If it's linked), BZ ticket reference is in the correct format in %changelog and/or commit message
  • [-] (If needed) Release is bumped
  • [-] (When adding patches) Patch purpose is documented in the specfile
  • [-] (When backporting patches) Patch origin and/or authorship is traceable
  • [-] (When creating patches from scratch) The patch is proposed upstream or justified as downstream-only

rebased onto 15acb6e

8 months ago

Pull-Request has been merged by churchyard

8 months ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/5864f6b116f549fba6c7487cfe580236

Metadata