PR#3: Do not fail on warnings - rpms/python-aiosignal

rpms / python-aiosignal

#3 Do not fail on warnings

Merged a year ago by music. Opened a year ago by thrnciar.

rpms/ thrnciar/python-aiosignal disable-deprecation-warnings into rawhide

Tomáš Hrnčiar • a year ago

b39be84

python-aiosignal.spec

file modified

		`@@ -59,6 +59,9 @@`
		`# Patch out coverage options`
		`sed -r -i 's/--cov[^[:blank:]]*//g' setup.cfg`

		`+ # Do not fail on warnings`
		`+ sed -zi 's/filterwarnings = error/filterwarnings = default/' setup.cfg`
		`+`

		`%generate_buildrequires`
		`%pyproject_buildrequires`

no initial comment

zuul commented a year ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/2007f37cdc4349159dbc4085aa056585

check-for-arches : SUCCESS in 2m 20s
rpm-scratch-build : SUCCESS in 11m 46s
rpm-linter : SUCCESS in 6m 24s (non-voting)
rpm-rpminspect : SUCCESS in 8m 30s (non-voting)
check-for-sti-tests : SUCCESS in 16s
check-for-fmf-tests : SUCCESS in 17s
rpm-install-test : SUCCESS in 1m 18s
Skipped 6 jobs

music commented a year ago

LGTM.

I tend to believe that erroring on DeprecationWarning, like C/C++ -Werror, is useful for upstream CI but too brittle with respect to interpeter/compiler and dependendency versions for downstream builds—although I don’t necessarily patch it out proactively when it isn’t causing problems.