PR#5: Explicitly opt in of the generator - rpms/python-dogpile-cache

rpms / python-dogpile-cache

#5 Explicitly opt in of the generator

Closed 3 years ago by jcapitao. Opened 3 years ago by jcapitao.

rpms/ jcapitao/python-dogpile-cache master into rawhide

Explicitly opt in of the generator

Joel Capitao • 3 years ago

a64199a

python-dogpile-cache.spec

file modified

+5 -1

		`@@ -1,3 +1,4 @@`
		`+ %{?python_enable_dependency_generator}`
		`%global modname dogpile.cache`
		`%global sum A caching front-end based on the Dogpile lock`
		`%global desc Dogpile consists of two subsystems, one building on top of the other.\`
		`@@ -23,7 +24,7 @@`

		`Name: python-dogpile-cache`
		`Version: 1.1.2`
		`- Release: 1%{?dist}`
		`+ Release: 2%{?dist}`
		`Summary: %{sum}`

		`License: MIT`
		`@@ -90,6 +91,9 @@`
		`%{python3_sitelib}/%{modname}-%{version}-*`

		`%changelog`
		`+ * Fri Feb 19 2021 Joel Capitao <jcapitao@redhat.com> - 1.1.2-2`
		`+ - Explicitly opt in of the generator`
		`+`
		`* Thu Jan 28 2021 Kevin Fenzi <kevin@scrye.com> - 1.1.2-1`
		`- Update to 1.1.2. Fixes rhbz#1920627`

jcapitao commented 3 years ago

We enable the dep generator to requires the deps below:

python3.9dist(decorator) >= 4
python3.9dist(stevedore)

We hit an issue on RDO because decorator dep was not found while running dogpile-cache [1].

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=62269200

[1] https://logserver.rdoproject.org/24/32024/1/check/DLRN-rpmbuild-centos8/e13913e/job-output.txt

kevin commented 3 years ago

huh. I don't understand this... the deps seem the same to me?

➜ ~ rpm -qp python3-dogpile-cache-1.1.2-2.fc35.noarch.rpm --requires
python(abi) = 3.9
python3-mako
python3.9dist(decorator) >= 4
python3.9dist(stevedore)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1

➜ ~ rpm -qp python3-dogpile-cache-1.1.2-1.fc34.noarch.rpm --requires
python(abi) = 3.9
python3-mako
python3.9dist(decorator) >= 4
python3.9dist(stevedore)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1

jcapitao commented 3 years ago

Indeed, sorry for not having bring out more details.
In RDO, we rebuild packages (mainly deps) against CBS from Fedora distgit.
We don't have dep generator enabled in our buildroot, that's why I've requested
explicit enablement. But since then, folks pointed me that the dep generator is added
before the rebuild in RDO! So no needs here :)

Pull-Request has been closed by jcapitao

3 years ago