rpms / python-eventlet

Clone
Source Code
GIT

#13 conditionally disable docs on el
Opened 2 months ago by ktdreyer. Modified 2 months ago
rpms/ ktdreyer/python-eventlet docs-conditional  into  rawhide

Merge
conditionally disable docs on el9
Ken Dreyer • 2 months ago  
20ac7fe
file modified
+12 -1 
@@ -8,7 +8,12 @@ 
 

  # RHEL9 doesn't have nose, and it won't be added to EPEL9 because it's
 

  # abandoned upstream (and deprecated in Fedora).
 

  # https://bugzilla.redhat.com/show_bug.cgi?id=2041068
 

- %if %{undefined el9}
 

+ # and the docs require zmq/zeromq.
 

+ %if 0%{?rhel}
 

+ %bcond_with  docs
 

+ %bcond_with  tests
 

+ %else
 

+ %bcond_without  docs
 

  %bcond_without  tests
 

  %endif
 

  
@@ -39,6 +44,7 @@ 
 

  

  %description -n python3-%{srcname} %{_description}
 

  

+ %if %{with docs}
 

  %package -n python3-%{srcname}-doc
 

  Summary:        Documentation for python3-%{srcname}
 

  BuildRequires:  make
 
@@ -47,6 +53,7 @@ 
 

  

  %description -n python3-%{srcname}-doc
 

  %{summary}.
 

+ %endif
 

  

  %prep
 

  %autosetup -p1 -n %{srcname}-%{version}
 
@@ -56,7 +63,9 @@ 
 

  

  %build
 

  %pyproject_wheel
 

+ %if %{with docs}
 

  %make_build -C doc html
 

+ %endif
 

  

  %install
 

  %pyproject_install
 
@@ -74,9 +83,11 @@ 
 

  %files -n python3-%{srcname} -f %{pyproject_files}
 

  %doc README.rst AUTHORS NEWS
 

  

+ %if %{with docs}
 

  %files -n python3-%{srcname}-doc
 

  %license LICENSE
 

  %doc doc/_build/html
 

+ %endif
 

  

  %changelog
 

  * Fri Jan 26 2024 Fedora Release Engineering <releng@fedoraproject.org> - 0.33.3-5

This removes the dependency on python3-zmq, which also pulls in zeromq.

This makes it easier to bootstrap this package in minimal environments where zeromq is not necessary.

(Note most container environments do not install docs, also.)

Related but not blocking: Is there a reason to limit this conditional to EL 9 rather than all EL versions?

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/fc331e8f0f874962a3664ec77de60e0c

rebased onto 20ac7fe
2 months ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/5e816a4e9e5044c6b3ef11ac40644a82

Sure @churchyard, that's a good idea to apply this to all el versions. I've amended this PR to do that.

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/47ddd9870d1645939a6565e50344d901
Metadata
None
No Tags
Changes Summary 1
+12 -1
file changed
python-eventlet.spec
Powered by Pagure 5.13.3
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.