PR#4: Add workaround for Flask 2.2 support - rpms/python-flask-sqlalchemy

rpms / python-flask-sqlalchemy

#4 Add workaround for Flask 2.2 support

Merged 2 years ago by frantisekz. Opened 2 years ago by frantisekz.

rpms/ frantisekz/python-flask-sqlalchemy flask-2.2 into rawhide

Add workaround for Flask 2.2 support

František Zatloukal • 2 years ago

26449c9

python-flask-sqlalchemy.spec

file modified

+7 -2

		`@@ -2,7 +2,7 @@`

		`Name: python-flask-sqlalchemy`
		`Version: 2.5.1`
		`- Release: 6%{?dist}`
		`+ Release: 7%{?dist}`
		`Summary: Adds SQLAlchemy support to Flask application`

		`License: BSD`
		`@@ -51,7 +51,9 @@`
		`%py3_install`

		`%check`
		`- %pytest`
		`+ # We expect 2 warnings in one test due to Flask >= 2.2.0`
		`+ # Upstream report: https://github.com/pallets-eco/flask-sqlalchemy/issues/1068`
		`+ %pytest --deselect tests/test_basic_app.py::test_persist_selectable`

		`%files -n python3-flask-sqlalchemy`
		`%license LICENSE.rst`
		`@@ -60,6 +62,9 @@`
		`%{python3_sitelib}/flask_sqlalchemy/`

		`%changelog`
		`+ * Wed Aug 03 2022 Frantisek Zatloukal <fzatlouk@redhat.com> - 2.5.1-7`
		`+ - Add workaround for Flask 2.2 support`
		`+`
		`* Fri Jul 22 2022 Fedora Release Engineering <releng@fedoraproject.org> - 2.5.1-6`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild`

no initial comment

rebased onto 9102916

2 years ago

cstratak commented on line 14 of python-flask-sqlalchemy.spec 2 years ago

Nitpick: This could be Patch0

cstratak commented on line 14 of python-flask-sqlalchemy.spec 2 years ago

However on a closer look, IMHO it would be better to just disable the test during the pytest command line invocation instead of patching the code, I think it's cleaner that way. With a comment above the pytest command line invocation.

Something like this should work: %pytest --deselect tests/test_basic_app.py::test_persist_selectable

rebased onto 26449c9

2 years ago

frantisekz commented 2 years ago

Yep, far cleaner approach, change force-pushed, thanks!

cstratak commented 2 years ago

I think everything looks good for merging.

Pull-Request has been merged by frantisekz

2 years ago