PR#34: WIP: python 3.10 compatibility, disable failing tests - rpms/python-matplotlib

rpms / python-matplotlib

#34 WIP: python 3.10 compatibility, disable failing tests

Closed 3 years ago by thrnciar. Opened 3 years ago by thrnciar.

rpms/ thrnciar/python-matplotlib disable-failing-tests into rawhide

python 3.10 compatibility, disable failing tests

Tomas Hrnciar • 3 years ago

a2b2ebd

python-matplotlib.spec

file modified

+4 -1

		`@@ -375,13 +375,16 @@`
		`# Skips:`
		`# * test_invisible_Line_rendering: Checks for "slowness" that often fails on a`
		`# heavily-loaded builder.`
		`+ # * test_fork, test_savefig_backend, test_load_from_url, test_use_url:`
		`+ # These tests are diabled due to compatibility issues with Python 3.10 and`
		`+ # can be enabled once they are fixed.`
		`MPLCONFIGDIR=$PWD \`
		`PYTHONPATH=%{buildroot}%{python3_sitearch} \`
		`PYTHONDONTWRITEBYTECODE=1 \`
		`xvfb-run -a -s "-screen 0 640x480x24" \`
		`%{python3} tests.py -ra -n $(getconf _NPROCESSORS_ONLN) \`
		`-m 'not network' \`
		`- -k 'not test_invisible_Line_rendering and not Qt5Agg'`
		`+ -k 'not test_invisible_Line_rendering and not Qt5Agg and not test_fork and not test_savefig_backend and not test_load_from_url and not test_use_url'`
		`# Run Qt5Agg tests separately to not conflict with Qt4 tests.`
		`MPLCONFIGDIR=$PWD \`
		`PYTHONPATH=%{buildroot}%{python3_sitearch} \`

thrnciar commented 3 years ago

We need matplotlib to build during the bootstrap sequence of Python 3.10. I'd like to temporarily disable failing tests until they are fixed in the upstream.

zuul commented 3 years ago

Build succeeded.

check-for-arches : SUCCESS in 1m 11s
rpm-scratch-build : SUCCESS in 12m 31s
rpm-scratch-build-s390x : SUCCESS in 13m 19s (non-voting)
rpm-scratch-build-ppc64le : SUCCESS in 15m 15s (non-voting)
rpm-scratch-build-i686 : SUCCESS in 13m 25s (non-voting)
rpm-scratch-build-armv7hl : SUCCESS in 24m 11s (non-voting)
rpm-scratch-build-aarch64 : SUCCESS in 19m 28s (non-voting)
rpm-linter : SUCCESS in 5m 11s
rpm-rpminspect : SUCCESS in 12m 07s (non-voting)
check-for-tests : SUCCESS in 38s
rpm-install-test : SUCCESS in 3m 57s
rpm-test : SKIPPED

qulogic commented 3 years ago

But this is a bug in Python 3.10? Why would you not fix it there?

thrnciar commented 3 years ago

We are close to starting the rebuilds of Python packages in the sidetag. To be able to do so all packages that are in the bootstrap sequence need to build. There are still plenty of them that don't and we are unable to properly fix them all thus I am opening PRs like this to temporarily disable problematic tests.

@churchyard in his Bugzilla mentioned where the problem lies:

This problematic code is in pygobject, but matplotlib might be fixed by not treating this warning as error.

If you can help us and propose a proper fix, it would be much better than disabling the tests, but I cannot spend more time on this right now.

churchyard commented 3 years ago

Ideally, we turn off the treat-the-warning-as-error somehow.

churchyard commented 3 years ago

I'm working on a fix for pygobject, don't merge this just yet.

zuul commented 3 years ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

check-for-arches : FAILURE in 1m 29s
rpm-scratch-build : FAILURE in 2m 40s
rpm-scratch-build-s390x : SKIPPED (non-voting)
rpm-scratch-build-ppc64le : SKIPPED (non-voting)
rpm-scratch-build-i686 : SKIPPED (non-voting)
rpm-scratch-build-armv7hl : SKIPPED (non-voting)
rpm-scratch-build-aarch64 : SKIPPED (non-voting)
rpm-linter : SKIPPED
rpm-rpminspect : SKIPPED (non-voting)
check-for-tests : SKIPPED
rpm-install-test : SKIPPED
rpm-test : SKIPPED

churchyard commented 3 years ago

https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/174 gets this fixed. I propose we close this and backport that one instead.

qulogic commented 3 years ago

Ideally, we turn off the treat-the-warning-as-error somehow.

Well, pytest supports passing a warning filter with -W just like Python. However, one of those is a test in a subprocess, so it'd have to be ignored with the PYTHONWARNINGS environment variable.

thrnciar commented 3 years ago

Closing in favour of https://src.fedoraproject.org/rpms/pygobject3/pull-request/3.

Pull-Request has been closed by thrnciar

3 years ago