PR#2: Update to version 0.17.1 - rpms/python-scikit-build

rpms / python-scikit-build

#2 Update to version 0.17.1

Merged a year ago by lecris. Opened a year ago by lecris.

rpms/ lecris/python-scikit-build rawhide into rawhide

Bump version to 0.17.1

Cristian Le • a year ago

81b3a0a

Change to autospec

Cristian Le • a year ago

7262ab5

.gitignore

file modified

		`@@ -1,2 +1,3 @@`
		`/scikit-build-0.16.6.tar.gz`
		`/scikit-build-0.16.7.tar.gz`
		`+ /scikit_build-0.17.1.tar.gz`

changelog

file added

+10

		`@@ -0,0 +1,10 @@`
		`+ * Thu Apr 13 2023 Cristian Le <fedora@lecris.me> - 0.17.1`
		`+ - Update to 0.17.1`
		`+ - Pypi archive name changed`
		`+ - Switched to autospec`
		`+`
		`+ * Fri Feb 17 2023 Tomáš Hrnčiar <thrnciar@redhat.com> - 0.16.7-1`
		`+ - Update to 0.16.7`
		`+`
		`+ * Thu Feb 09 2023 Tomáš Hrnčiar <thrnciar@redhat.com> - 0.16.6-1`
		`+ - Initial package`

python-scikit-build.spec

file modified

+7 -9

		`@@ -1,6 +1,8 @@`
		`+ %global pypi_name scikit_build`
thrnciar commented a year ago In my team, we are shifting away from globals like this. It reduces the spec file readability and the benefit of having it defined in one place is quite small since it is used only in two places. Also the pypi archive name doesn't change that often.
		`+`
		`Name: python-scikit-build`
		`- Version: 0.16.7`
		`- Release: 1%{?dist}`
		`+ Version: 0.17.1`
		`+ Release: %{autorelease}`
		`Summary: Improved build system generator for Python C/C++/Fortran/Cython extensions`

		`# This project is mainly MIT but LICENSE also mentions some code`
		`@@ -8,7 +10,7 @@`
		`# All bundled(cmake()) files listed are Apache-2.0 licensed.`
		`License: MIT AND BSD-2-Clause-Views AND Apache-2.0`
		`URL: https://github.com/scikit-build/scikit-build`
		`- Source: %{pypi_source scikit-build}`
		`+ Source0: %{pypi_source %{pypi_name}}`
thrnciar commented a year ago What's your motivation for adding numbered Source? It's not necessary nowadays.

		`BuildArch: noarch`
		`BuildRequires: python3-devel`
		`@@ -52,7 +54,7 @@`


		`%prep`
		`- %autosetup -p1 -n scikit-build-%{version}`
		`+ %autosetup -n %{pypi_name}-%{version}`


		`%generate_buildrequires`
		`@@ -83,8 +85,4 @@`


		`%changelog`
		`- * Fri Feb 17 2023 Tomáš Hrnčiar <thrnciar@redhat.com> - 0.16.7-1`
		`- - Update to 0.16.7`
		`-`
		`- * Thu Feb 09 2023 Tomáš Hrnčiar <thrnciar@redhat.com> - 0.16.6-1`
		`- - Initial package`
		`+ %autochangelog`

sources

file modified

+1 -1

		`@@ -1,1 +1,1 @@`
		`- SHA512 (scikit-build-0.16.7.tar.gz) = 5bba94214c249f891b2972301b0e37b5f10938151e37a04b845dfc9e11ae85edc7e3880984f9fbbd1c037257fc8baa3ba7b006b1f1b7abb941d1a54e049f3cbc`
		`+ SHA512 (scikit_build-0.17.1.tar.gz) = 617a68d92787c576f1c3fc9c24c8cc90e1fe976a853f3ae81442e1a99a20e1f4049d7ffac967c2248bf172f07a3e2092fc28b8d558b35da628a58cd3d9d16ae3`

lecris commented a year ago

Changed to autochangelog
pypi name has changed to scikit_build

zuul commented a year ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/427777ab0f9147a7ba139243b629ef0a

check-for-arches : SUCCESS in 2m 44s
rpm-scratch-build : SUCCESS in 14m 37s
rpm-linter : SUCCESS in 5m 10s (non-voting)
rpm-rpminspect : SUCCESS in 7m 24s (non-voting)
check-for-sti-tests : SUCCESS in 16s
check-for-fmf-tests : SUCCESS in 17s
rpm-install-test : SUCCESS in 1m 41s
Skipped 6 jobs

lecris commented a year ago

@thrnciar Do you want to run your dependency tool for this one?

thrnciar commented a year ago

Yes, I'll do it.

thrnciar commented a year ago

Impact check looks good https://copr.fedorainfracloud.org/coprs/thrnciar/python-scikit-build/builds/.

Pull-Request has been merged by lecris

a year ago

lecris commented a year ago

Clear for f38?

thrnciar commented on line 2 of python-scikit-build.spec a year ago

In my team, we are shifting away from globals like this. It reduces the spec file readability and the benefit of having it defined in one place is quite small since it is used only in two places. Also the pypi archive name doesn't change that often.

thrnciar commented on line 17 of python-scikit-build.spec a year ago

What's your motivation for adding numbered Source? It's not necessary nowadays.

lecris commented a year ago

In my team, we are shifting away from globals like this. It reduces the spec file readability and the benefit of having it defined in one place is quite small since it is used only in two places. Also the pypi archive name doesn't change that often.

Yeah, I saw some comments on that as well. I'll try to do that in the next refactor