#9 EPEL 8 compat
Closed 5 years ago by kanarip. Opened 5 years ago by kanarip.
rpms/ kanarip/python-sphinx epel8  into  master

file modified
+9 -1
@@ -57,6 +57,9 @@ 

  # which causes that test to fail.

  Patch1: sphinx-test_theming.diff

  

+ # Really exclude websupport if so specified

+ Patch2: websupport.patch

+ 

  BuildArch:     noarch

  BuildRequires: python2-devel >= 2.4

  BuildRequires: python2-babel
@@ -395,7 +398,12 @@ 

  This package contains locale files for Sphinx

  

  %prep

- %autosetup -n %{upstream_name}-%{version}%{?prerel} -p1

+ %setup -q -n %{upstream_name}-%{version}%{?prerel}

+ %patch0 -p1

+ %patch1 -p1

+ %if ! %{with websupport}

+ %patch2 -p1

+ %endif

  

  cp %{SOURCE5} .

  

file added
+33
@@ -0,0 +1,33 @@ 

+ diff -ur Sphinx-1.8.4.orig/setup.py Sphinx-1.8.4/setup.py

+ --- Sphinx-1.8.4.orig/setup.py	2019-02-03 15:12:13.000000000 +0100

+ +++ Sphinx-1.8.4/setup.py	2019-03-06 18:53:33.801577031 +0100

+ @@ -27,7 +27,6 @@

+      'requests>=2.0.0',

+      'setuptools',

+      'packaging',

+ -    'sphinxcontrib-websupport',

+  ]

+  

+  extras_require = {

+ @@ -38,10 +37,6 @@

+      ':python_version<"3.5"': [

+          'typing'

+      ],

+ -    'websupport': [

+ -        'sqlalchemy>=0.9',

+ -        'whoosh>=2.0',

+ -    ],

+      'test': [

+          'mock',

+          'pytest',

+ diff -ur Sphinx-1.8.4.orig/Sphinx.egg-info/requires.txt Sphinx-1.8.4/Sphinx.egg-info/requires.txt

+ --- Sphinx-1.8.4.orig/Sphinx.egg-info/requires.txt	2019-02-03 15:15:59.000000000 +0100

+ +++ Sphinx-1.8.4/Sphinx.egg-info/requires.txt	2019-03-06 18:40:24.384208948 +0100

+ @@ -9,7 +9,6 @@

+  requests>=2.0.0

+  setuptools

+  packaging

+ -sphinxcontrib-websupport

+  

+  [:python_version<"3.5"]

+  typing

In order for EPEL 8 bootstrapping, it would be helpful for python{2,3}-sphinx to not depend on -websupport.

This patch allows for the build conditional to strip out websupport from the runtime dependencies, avoiding a loop between -sphinx and, for example, -whoosh.

What if we wait for Sphinx 2, where the dependency is no longer present?

Also note that this will conflict with https://src.fedoraproject.org/rpms/python-sphinx/pull-request/8 so please don't put this to master please.

Of course you're just fine in moving PR8 forward, and even waiting for Sphinx 2 or somesuch.

Meanwhile, we'd be applying this patch downstream for as long as it is both needed and succeeds to apply ;-)

OK. Thanks

Sphinx 2.0.0 merged. Please update this to whatever you actually need or close it if this remains epel8 only.

No update to the branch this pull request has been created against, I'm currently just entertaining this for bootstrappping el8 rebuilds.

Pull-Request has been closed by kanarip

5 years ago