PR#2: Fix FTBFS and remove python-crypto dependency - rpms/python-twisted

rpms / python-twisted

#2 Fix FTBFS and remove python-crypto dependency

Merged 6 years ago by cstratak. Opened 6 years ago by pviktori.

rpms/ pviktori/python-twisted portmap-crypto into master

No longer require python-crypto

Petr Viktorin • 6 years ago

6746a26

Don't fix permission on portmap.so

Petr Viktorin • 6 years ago

c060ac9

python-twisted.spec

file modified

+4 -6

		`@@ -4,7 +4,7 @@`

		`Name: python-twisted`
		`Version: 16.4.1`
		`- Release: 8%{?dist}`
		`+ Release: 9%{?dist}`
		`Summary: Twisted is a networking engine written in Python`
		`License: MIT`
		`URL: http://twistedmatrix.com/`
		`@@ -23,7 +23,6 @@`

		`BuildRequires: python2-devel >= 2.6`
		`BuildRequires: python2-zope-interface >= 3.6.0`
		`- BuildRequires: python2-crypto >= 2.6.1`
		`BuildRequires: python2-pyOpenSSL >= 0.10`
		`BuildRequires: python2-service-identity`
		`BuildRequires: python2-setuptools`
		`@@ -63,7 +62,6 @@`
		`Provides: twisted = %{version}-%{release}`

		`# python-twisted-conch`
		`- Requires: python2-crypto`
		`Requires: python2-pyasn1`

		`# python-twisted-core`
		`@@ -84,7 +82,6 @@`

		`BuildRequires: python3-devel >= 3.3`
		`BuildRequires: python3-zope-interface >= 4.0.2`
		`- BuildRequires: python3-crypto >= 2.6.1`
		`BuildRequires: python3-pyOpenSSL >= 0.10`
		`BuildRequires: python3-service-identity`
		`BuildRequires: python3-setuptools`
		`@@ -94,7 +91,6 @@`
		`Requires: python3-service-identity`

		`# python-twisted-conch`
		`- Requires: python3-crypto`
		`Requires: python3-pyasn1`

		`# python-twisted-core`
		`@@ -177,7 +173,6 @@`

		`# non-standard-executable-perm`
		`%{__chmod} 755 %{buildroot}%{python2_sitearch}/twisted/python/_sendmsg.so`
		`- %{__chmod} 755 %{buildroot}%{python2_sitearch}/twisted/runner/portmap.so`
		`%{__chmod} 755 %{buildroot}%{python2_sitearch}/twisted/test/raiser.so`

		`# Move and symlink python2 scripts`
		`@@ -234,6 +229,9 @@`


		`%changelog`
		`+ * Fri Apr 27 2018 Petr Viktorin <pviktori@redhat.com> - 16.4.1-9`
		`+ - No longer require python-crypto`
		`+`
		`* Mon Mar 26 2018 Iryna Shcherbina <ishcherb@redhat.com> - 16.4.1-8`
		`- Update Python 2 dependency declarations to new packaging standards`
		`(See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3)`

pviktori commented 6 years ago

portmap.so no longer builds, due to "rpc/rpc.h" not being available in Fedora (see twisted/python/dist.py). Don't fix up its permissions.
All functionality involving Crypto has been replaced by python-cryptography, or deprecated and made optional. So, there's no longer a reason for python-twisted to always pull in python-crypto.