rpms / quazip

Clone
Source Code
GIT

#16 Update to 1.4
Closed a year ago by omos. Opened a year ago by topazus.
rpms/ topazus/quazip rawhide  into  rawhide

file modified
+4 -3 
@@ -13,11 +13,11 @@ 
 

  %bcond_without test
 

  

  # see top-ldevel CMakeLists.txt for variables of same name
 

- %global QUAZIP_LIB_VERSION %{version} 

- %global QUAZIP_LIB_SOVERSION 1.3.0
 

+ %global QUAZIP_LIB_VERSION %{version}
 

+ %global QUAZIP_LIB_SOVERSION 1.4.0
 

  

  Name:		quazip
 

- Version:	1.3
 

+ Version:	1.4
 

  Release:	%autorelease
 

  Summary:	Qt/C++ wrapper for the minizip library
 

  License:	GPLv2+ or LGPLv2+
 
@@ -28,6 +28,7 @@ 
 

  BuildRequires:	cmake
 

  BuildRequires:	gcc-c++
 

  BuildRequires:	zlib-devel
 

+ BuildRequires:	pkgconfig(bzip2)
 

  %if %{with qt4}
 

  BuildRequires:	qt4-devel
 

  %endif

no initial comment

rebased onto ef29b53
a year ago

Nack. There are several issues here:

  1. This update would bump soname, and thus all dependent packages will need to be rebuilt. However, at least bletchmame currently fails to build [1] and the maintainer hasn't fixed it yet, so we need to wait (otherwise blechmame would become uninstallable after this update).
  2. Your PR removes FindQuaZip.cmake, but it is still needed as not all dependent packages have migrated to the new 1.x CMake interface - e.g. nomacs [2].
  3. Version 1.4 has added bzip2 support, which is activated automatically when the library is present. We should add BuildRequires: pkgconfig(bzip2) to ship with bzip2 support enabled.
  4. Don't modify the changelog file. This package uses rpmautospec [3], so you should instead split your changes into commits and describe each one in the commit message.
  5. You should mention the Upstream Release Monitoring BZ [4] in the commit message to get it included in the changelog and have Bodhi autoclose the bug (see old commits for an example).

The other changes (enabling __cmake_in_source_build, switching to %ctest, and removing %ldconfig_scriptlets) seem fine, though - I'd suggest to submit them in a separate PR (each change in its own commit, please).

[1] https://bugzilla.redhat.com/show_bug.cgi?id=2169500
[2] https://src.fedoraproject.org/rpms/nomacs/pull-request/4
[3] https://docs.pagure.org/Fedora-Infra.rpmautospec/index.html
[4] https://bugzilla.redhat.com/show_bug.cgi?id=2164261

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/ebc29421c26846e7b0a122803f5a6b30

I have submitted the other modifications to another pr, which is removing __cmake_in_source_build, removing ldconfig scriptlets and switching to %ctest macro.

rebased onto 4cf5b19
a year ago

rebased onto c37c7fe
a year ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/38c5c9423bd7438496a8bf098b3d84da

rebased onto 4158dbf
a year ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/191273dc093e41e28bf0fe8f1ba52705

@kwizart already did the update to 1.4, so this PR is now obsolete.

Pull-Request has been closed by omos
a year ago
Metadata
None
No Tags
Changes Summary 1
+4 -3
file changed
quazip.spec
Powered by Pagure 5.13.3
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.