#3 Add a check to trivial compile of a hip file
Opened a year ago by trix. Modified a year ago
rpms/ trix/rocm-device-libs rawhide  into  rawhide

file modified
+9 -1
@@ -15,7 +15,7 @@ 

  

  Name:           rocm-device-libs

  Version:        %{llvm_maj_ver}.%{bugfix_version}

- Release:        1%{?dist}

+ Release:        2%{?dist}

  Summary:        AMD ROCm LLVM bit code libraries

  

  Url:            https://github.com/RadeonOpenCompute/ROCm-Device-Libs
@@ -55,6 +55,11 @@ 

  %install

  %cmake_install

  

+ %check

+ # a trival hip file should find the device libs now

+ touch t.hip

+ clang -c t.hip

+ 

  %files

  %license LICENSE.TXT

  %doc README.md doc/*.md
@@ -64,6 +69,9 @@ 

  %{_libdir}/clang/%{llvm_maj_ver}/amdgcn

  

  %changelog

+ * Tue Jun 06 2023 Tom Rix <trix@redhat.com> - 16.2-2

+ - Add trival compile of a hip file to check install

+ 

  * Thu Jun 01 2023 Jeremy Newton <alexjnewt at hotmail dot com> - 16.2-1

  - Update to 16.2

  

Afther the install clang should find the device libs by default
if the libs were installed correctly.

Signed-off-by: Tom Rix trix@redhat.com

It looks like the scratch build failed.

The problem is that your test is a post install test, but %check happens post build. Does Fedora infra allow post install tests? Like a custom CI test or something?

I'm going to need to read through the docs:
https://docs.fedoraproject.org/en-US/ci/

With that said, right now there's some good tests in rocm-compilersupport relating to device libs, so CI might have limited value right now, as I always update them together.

Alternatively, I don't mind adding this check to the %check to rocm-compilersupport for the time being for redundancy.

Metadata