From 8b7369a527aa52204e1ce529c8cb206cfee4c61b Mon Sep 17 00:00:00 2001 From: Mattias Ellert Date: Fri, 17 Nov 2023 16:18:12 +0100 Subject: [PATCH] Disable tests that don't compile with old gtest (EPEL 8) --- core/metacling/test/TClingLoadUnloadFileTests.cxx | 2 ++ roofit/histfactory/test/testHistFactory.cxx | 2 ++ roofit/roofitcore/test/testRooProdPdf.cxx | 2 ++ roofit/roofitcore/test/testTestStatistics.cxx | 2 ++ 4 files changed, 8 insertions(+) diff --git a/core/metacling/test/TClingLoadUnloadFileTests.cxx b/core/metacling/test/TClingLoadUnloadFileTests.cxx index 7f97f3f441..d1b7a65fbc 100644 --- a/core/metacling/test/TClingLoadUnloadFileTests.cxx +++ b/core/metacling/test/TClingLoadUnloadFileTests.cxx @@ -73,6 +73,7 @@ void remove_n_library_artifacts(const std::string &basename, unsigned int n) } } +/* TEST(TClingLoadUnloadFile, ConcurrentLoadUnloadSameLib) { GTEST_SKIP() << "fails sporadically, see " @@ -125,3 +126,4 @@ TEST(TClingLoadUnloadFile, ConcurrentLoadUnloadOneLibPerThread) remove_n_library_artifacts(basename, n_libraries); } +*/ diff --git a/roofit/histfactory/test/testHistFactory.cxx b/roofit/histfactory/test/testHistFactory.cxx index 7553ba4e4a..fefdca8e97 100644 --- a/roofit/histfactory/test/testHistFactory.cxx +++ b/roofit/histfactory/test/testHistFactory.cxx @@ -752,6 +752,7 @@ std::string getNameFromInfo(testing::TestParamInfo const & return getName(paramInfo.param, false); } +/* INSTANTIATE_TEST_SUITE_P( HistFactory, HFFixture, testing::Combine(testing::Values(MakeModelMode::OverallSyst, MakeModelMode::HistoSyst, MakeModelMode::StatSyst, @@ -784,3 +785,4 @@ INSTANTIATE_TEST_SUITE_P(HistFactoryCodeGen, HFFixtureFit, testing::Values(RooFit::EvalBackend::Codegen())), getNameFromInfo); #endif +*/ diff --git a/roofit/roofitcore/test/testRooProdPdf.cxx b/roofit/roofitcore/test/testRooProdPdf.cxx index 34fb559cd1..09734f5c5d 100644 --- a/roofit/roofitcore/test/testRooProdPdf.cxx +++ b/roofit/roofitcore/test/testRooProdPdf.cxx @@ -64,6 +64,7 @@ TEST_P(TestProdPdf, CachingOpt) << "b=" << b.getVal() << " +- " << b.getError() << " doesn't match truth value with O" << _optimize << "."; } +/* INSTANTIATE_TEST_SUITE_P(RooProdPdf, TestProdPdf, testing::Combine(testing::Values(0, 1, 2), testing::Values(ROOFIT_EVAL_BACKENDS)), @@ -72,6 +73,7 @@ INSTANTIATE_TEST_SUITE_P(RooProdPdf, TestProdPdf, ss << "opt" << std::get<0>(paramInfo.param) << std::get<1>(paramInfo.param).name(); return ss.str(); }); +*/ TEST(RooProdPdf, TestGetPartIntList) { diff --git a/roofit/roofitcore/test/testTestStatistics.cxx b/roofit/roofitcore/test/testTestStatistics.cxx index 3099d82060..5846353043 100644 --- a/roofit/roofitcore/test/testTestStatistics.cxx +++ b/roofit/roofitcore/test/testTestStatistics.cxx @@ -585,6 +585,7 @@ INSTANTIATE_TEST_SUITE_P(RooNLLVar, TestStatisticTest, testing::Values(ROOFIT_EV return ss.str(); }); +/* INSTANTIATE_TEST_SUITE_P(RooNLLVar, OffsetBinTest, testing::Combine(testing::Values(ROOFIT_EVAL_BACKENDS), // EvalBackend testing::Values(false, true), // unbinned or binned @@ -622,3 +623,4 @@ INSTANTIATE_TEST_SUITE_P(RooNLLVarBinnedL, OffsetBinTest, ss << (std::get<5>(paramInfo.param) ? "BinnedL" : ""); return ss.str(); }); +*/