PR#49: During the build, assert the Python modules are importable - rpms/rpm

rpms / rpm

#49 During the build, assert the Python modules are importable

Merged 10 days ago by churchyard. Opened 9 months ago by churchyard.

rpms/ churchyard/rpm py3_check_import into rawhide

During the build, assert the Python modules are importable

Miro Hrončok • 10 days ago

1bee3a5

rpm.spec

file modified

+9 -1

		`@@ -27,7 +27,7 @@`

		`%global rpmver 4.19.1.1`
		`#global snapver rc1`
		`- %global baserelease 1`
		`+ %global baserelease 2`
		`%global sover 10`

		`%global srcver %{rpmver}%{?snapver:-%{snapver}}`
		`@@ -372,6 +372,11 @@`

		`%make_build`

		`+ %check`
		`+ # We can't run the actual test-suite from %%check,`
		`+ # at least check the Python module is importable:`
		`+ LD_LIBRARY_PATH=%{buildroot}%{_libdir} %py3_check_import rpm rpm.transaction`
		`+`
		`%install`
		`cd _build`
		`%make_install`
		`@@ -614,6 +619,9 @@`
		`%doc %{_defaultdocdir}/rpm/API/`

		`%changelog`
		`+ * Mon May 06 2024 Miro Hrončok <mhroncok@redhat.com> - 4.19.1.1-2`
		`+ - During the build, assert the Python modules are importable`
		`+`
		`* Wed Feb 07 2024 Michal Domonkos <mdomonko@redhat.com> - 4.19.1.1-1`
		`- Update to 4.19.1.1 (https://rpm.org/wiki/Releases/4.19.1.1)`

no initial comment

churchyard commented 6 months ago

Hello. Should I rebase this or are you not interested?

pmatilai commented 6 months ago

Sorry, this seems to have fallen through cracks, I don't even recall seeing this before.

i do find it a bit peculiar as the sole %check for rpm. But then, we can't run the actual test-suite from %check anymore as the new container based version requires network access for the image creation...