PR#23: Disable gold linker on RISC-V - rpms/samba

rpms / samba

#23 Disable gold linker on RISC-V

Closed 2 years ago by imbearchild. Opened 2 years ago by imbearchild.

rpms/ imbearchild/samba riscv-fix into rawhide

David Abdurachmanov • 2 years ago

78b012c

samba.spec

file modified

+7 -1

		`@@ -1107,9 +1107,12 @@`
		`# TODO: resolve underlinked python modules`
		`export python_LDFLAGS="$(echo %{__global_ldflags} \| sed -e 's/-Wl,-z,defs//g')"`

		`- # Use the gold linker`
		`+ # Use the gold linker, except RISC-V (riscv64), which does not have gold`
		`# See https://bugzilla.redhat.com/show_bug.cgi?id=2043178 ; For f36 do not use ld.gold till it is fixed`
		`#export LDFLAGS="%%{__global_ldflags} -fuse-ld=gold"`
		`+ %ifnarch riscv64`
		`+ #export LDFLAGS="%{__global_ldflags} -fuse-ld=gold"`
		`+ %endif`

		`%configure \`
		`--enable-fhs \`
		`@@ -4422,6 +4425,9 @@`
		`- Use make macros`
		`https://fedoraproject.org/wiki/Changes/UseMakeBuildInstallMacro`

		`+ * Thu Jul 16 2020 David Abdurachmanov <david.abdurachmanvo@sifive.com> - 4.13.0rc1-1.0.riscv64`
		`+ - Add support for riscv64`
		`+`
		`* Tue Jul 14 2020 Andreas Schneider <asn@redhat.com> - 4.13.0rc1-1`
		`- Move mdssvc data files to correct package`

imbearchild commented 2 years ago

Signed-off-by: Nianqing Yao imbearchild@outlook.com and David Abdurachmanov david.abdurachmanvo@sifive.com

Co-authored-by: Nianqing Yao imbearchild@outlook.com

asn commented 2 years ago

It already is disabled, the line is commented out.

imbearchild commented 2 years ago

It already is disabled, the line is commented out.

Yes, but for different reasons. There is no gold linker for RISC-V. So I just move the patch from sifive to here, in case that the bug of gold linker is fixed, and someone just simply enable it without exception for RISC-V .

Edited 2 years ago by imbearchild

asn commented 2 years ago

The plan is to move to ld.mold as soon as possible.

Pull-Request has been closed by imbearchild

2 years ago

asn commented 2 years ago

https://bugzilla.redhat.com/show_bug.cgi?id=2082434 blocks us :-)