PR#15: Replace IO::Socket::INET6 by recommended IO::Socket::IP - rpms/spamassassin

rpms / spamassassin

#15 Replace IO::Socket::INET6 by recommended IO::Socket::IP

Merged 12 months ago by jplesnik. Opened 12 months ago by jplesnik.

Unknown source use_IO_Socket_IP into rawhide

Fixes rhbz#2218100

Jitka Plesnikova • 12 months ago

b7cdf74

Replace IO::Socket::INET6 by recommended IO::Socket::IP

Jitka Plesnikova • 12 months ago

a071ef6

spamassassin.spec

file modified

+7 -3

		`@@ -60,7 +60,7 @@`
		`Name: spamassassin`
		`Version: 4.0.0`
		`#Release: 0.8.%%{prerev}%%{?dist}`
		`- Release: 4%{?dist}`
		`+ Release: 5%{?dist}`
		`License: ASL 2.0`
		`URL: https://spamassassin.apache.org/`
		`Source0: https://www.apache.org/dist/%{name}/source/%{real_name}-%{version}.tar.bz2`
		`@@ -164,8 +164,8 @@`
		`Requires: perl(IO::Socket::SSL)`
		`BuildRequires: perl(IO::Socket::SSL)`
		`# Needed for IPv6`
		`- Requires: perl(IO::Socket::INET6)`
		`- BuildRequires: perl(IO::Socket::INET6)`
		`+ Requires: perl(IO::Socket::IP)`
		`+ BuildRequires: perl(IO::Socket::IP)`
		`%endif`
		`%if %{perl_devel}`
		`BuildRequires: perl-devel`
		`@@ -397,6 +397,10 @@`
		`%endif`

		`%changelog`
		`+ * Tue Jun 27 2023 Jitka Plesnikova <jplesnik@redhat.com> - 4.0.0-5`
		`+ - Replace IO::Socket::INET6 by recommended IO::Socket::IP. Fixes rhbz#2218100`
		`+`
		`+`
		`* Sun Apr 02 2023 Todd Zullinger <tmz@pobox.com> - 4.0.0-4`
		`- Verify upstream source signatures`

jplesnik commented 12 months ago

The module IO::Socket::INET6 is deprecated. Using of IP::Socket::IP is recommended.

It is mentioned also in Mail-SpamAssassin-4.0.0/INSTALL

  - IO::Socket::IP (from CPAN)
  - IO::Socket::INET6 (from CPAN)

    Installing IO::Socket::IP is recommended if spamd is to listen on IPv6
    sockets or if DNS queries should go to an IPv6 name server.  If
    IO::Socket::IP is not available, using a deprecated module
    IO::Socket::INET6 will be attempted, and in its absence the support for
    IPv6 will not be available.  Some plugins and underlying modules may
    also prefer IO::Socket::IP over IO::Socket::INET6.

It will help us reduce the number of dependencies on this deprecated module.

jplesnik commented 12 months ago

The CI failure is not related to the change, the tests are broken.

kevin commented 12 months ago

This looks completely reasonable. Can you include "Fixes rhbz#2218100" in the changelog so bodhi will close the bug when it goes stable? Otherwise looks good here.

1 new commit added

Fixes rhbz#2218100

12 months ago

Pull-Request has been merged by jplesnik

12 months ago

Metadata

Assignee

None

Tags

No Tags

Changes Summary 1

+7 -3

file changed

spamassassin.spec

rpms / spamassassin

Source Code

#15 Replace IO::Socket::INET6 by recommended IO::Socket::IP Merged 12 months ago by jplesnik. Opened 12 months ago by jplesnik. Unknown source use_IO_Socket_IP into rawhide

Metadata

Changes Summary 1

#15 Replace IO::Socket::INET6 by recommended IO::Socket::IP

Merged 12 months ago by jplesnik. Opened 12 months ago by jplesnik.

Unknown source use_IO_Socket_IP into rawhide