#20 Move man pages to main package
Closed 4 years ago by pvalena. Opened 4 years ago by pvalena.
rpms/ pvalena/vagrant rebase  into  master

file modified
+1 -1
@@ -1,2 +1,2 @@ 

- SHA512 (vagrant-2.2.5.tar.gz) = dc95e566588987b9199e66ee5f548be573bd62e229d2e4de5447f43f25a1a7129377935ec6dc73cc1f53acc29c08b0a4fabebf1a58310f175cc6d37b856c9272

+ SHA512 (vagrant-2.2.6.tar.gz) = 6d8b5b1d4e5cc482404cf4c59e1b7cf9502a9819569b5098e44874733cee706f26adb4ac7994abe7e3307ca69d3003e2604dc859ce460c53d766d78b8d9fe22a

  SHA512 (vagrant-spec-abfc34474d122235d56e4c6b6fb5d3e35bedfa90.tar.gz) = cbb60d661d34b37bc5d414da0b2a31f39e2910c11251e334da5efbd8f010b5bd428bc1ae476fcb9b42ec4e8f8c6265292ba3f8f543625178ecb85aad06e8856f

file modified
+19 -9
@@ -5,7 +5,7 @@ 

  %bcond_without help2man

  

  Name: vagrant

- Version: 2.2.5

+ Version: 2.2.6

  Release: 1%{?dist}

  Summary: Build and distribute virtualized development environments

  License: MIT
@@ -39,7 +39,7 @@ 

  Requires: rubygem(hashicorp-checkpoint) >= 0.1.5

  Requires: rubygem(childprocess) >= 0.5.0

  Requires: rubygem(erubis) >= 2.7.0

- Requires: rubygem(i18n) >= 1.1.0

+ Requires: (rubygem(i18n) >= 1.1.1 with rubygem(i18n) < 2.0)

  Requires: rubygem(json)

  Requires: rubygem(listen) >= 3.1.5

  Requires: rubygem(log4r) >= 1.1.9
@@ -55,8 +55,6 @@ 

  Recommends: rubygem(bcrypt_pbkdf)

  Recommends: rubygem(ed25519)

  

- Requires(pre): shadow-utils

- 

  BuildRequires: bsdtar

  BuildRequires: ruby

  BuildRequires: rubygems-devel
@@ -78,7 +76,7 @@ 

  BuildRequires: rubygem(webmock)

  BuildRequires: rubygem(fake_ftp)

  BuildRequires: pkgconfig(bash-completion)

- %if ! %{without help2man}

+ %if %{with help2man}

  BuildRequires: help2man

  %endif

  BuildRequires: %{_bindir}/ssh
@@ -144,6 +142,11 @@ 

  %gemspec_remove_dep -s %{name}.gemspec -g rubyzip '~> 1.2.2'

  %gemspec_add_dep -s %{name}.gemspec -g rubyzip

  

+ # Allow newer i18n version

+ # https://github.com/hashicorp/vagrant/pull/11146

+ %gemspec_remove_dep -s %{name}.gemspec -g i18n '~> 1.1.1'

+ %gemspec_add_dep -s %{name}.gemspec -g i18n

+ 

  # Remove optional dependencies

  %gemspec_remove_dep -s %{name}.gemspec -g ed25519

  %gemspec_remove_dep -s %{name}.gemspec -g bcrypt_pbkdf
@@ -194,7 +197,7 @@ 

  touch %{buildroot}%{vagrant_plugin_conf}

  ln -s -t %{buildroot}%{vagrant_embedded_dir}/ %{vagrant_plugin_conf}

  

- %if ! %{without help2man}

+ %if %{with help2man}

  # Turn `vagrant --help` into man page.

  export GEM_PATH="%{gem_dir}:%{buildroot}/usr/share/vagrant/gems"

  # Needed to display help page without a warning.
@@ -245,6 +248,9 @@ 

  sed -i '/^    it "generates a network name and configuration" do$/,/^    end/ s/^/#/' \

    test/unit/plugins/providers/docker/action/prepare_networks_test.rb

  

+ # Remove failing BSD-host tests, as we don't care about those.

+ rm -rf test/unit/plugins/hosts/bsd

+ 

  # Rake solves the requires issues for tests

  rake -f tasks/test.rake test:unit

  
@@ -346,6 +352,9 @@ 

  %dir %{bashcompletion_dir}

  %{bashcompletion_dir}/%{name}

  %{_rpmconfigdir}/macros.d/macros.%{name}

+ %if %{with help2man}

+ %{_mandir}/man1/%{name}.1*

+ %endif

  

  %files doc

  %doc %{vagrant_plugin_instdir}/RELEASE.md
@@ -354,11 +363,12 @@ 

  %{vagrant_plugin_instdir}/Rakefile

  %{vagrant_plugin_instdir}/tasks

  %{vagrant_plugin_instdir}/vagrant-spec.config.example.rb

- %if ! %{without help2man}

- %{_mandir}/man1/%{name}.1*

- %endif

  

  %changelog

+ * Tue Oct 15 2019 Pavel Valena <pvalena@redhat.com> - 2.2.6-1

+ - Upgrade to Vagrant 2.2.6.

+ - Move man pages to main package

+ 

  * Wed Aug 14 2019 Pavel Valena <pvalena@redhat.com> - 2.2.5-1

  - Update to Vagrant 2.2.5.

  

and ehnance/simplify help2man bcond_with syntax.

Also: Use Suggests instead of Recommends for packages not in Fedora,
and shadow-utils are also no longer used in pre and thus not BRequired.


I plan to backport this up to f30.

Koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=37242706

Copr:
https://copr.fedorainfracloud.org/coprs/build/1019743

Smoke test: ok

Packages installed:

  • vagrant-2.2.5-2.fc32.noarch
  • vagrant-libvirt-0.0.45-5.fc30.noarch
  • ruby-2.6.3-122.fc31.x86_64
  • rubygems-3.0.3-122.fc31.noarch
  • rubygem-net-ssh-5.1.0-2.fc31.noarch
  • rubygem-i18n-1.1.1-4.fc31.noarch
  • rubygem-childprocess-1.0.1-4.fc31.noarch
  • rubygem-ruby-libvirt-0.7.1-6.fc31.x86_64
  • rubygem-fog-core-2.1.2-3.fc31.noarch
  • rubygem-fog-json-1.2.0-3.fc31.noarch
  • rubygem-fog-libvirt-0.6.0-1.fc31.noarch

Well, there's a double-send bug I found for you :))

Why use Suggests instead of Recommends? Suggests does nothing. Recommends installs if available ...

Actually, because it's not packaged, there's no reason to think that it will work together when it gets packaged. So Suggests does not change anything at this point, but may 'save' Vagrant from breaking in case someone packages it.

Actually, because it's not packaged, there's no reason to think that it will work together when it gets packaged. So Suggests does not change anything at this point, but may 'save' Vagrant from breaking in case someone packages it.

I have exactly opposite opinion. Not mentioning you were about to package these optional dependencies AFAIR.

I have exactly opposite opinion. Not mentioning you were about to package these optional dependencies AFAIR.

Ok, let's keep it then as is.
I'll package it allright, but I'm unsure when that'll be :))

Otherwise the man move is ok?

I have exactly opposite opinion. Not mentioning you were about to package these optional dependencies AFAIR.

Ok, let's keep it then as is.

Thx

I'll package it allright, but I'm unsure when that'll be :))

Np

Otherwise the man move is ok?

man pages should be in the main package, so the change is correct I suppose

1 new commit added

  • Upgrade to Vagrant 2.2.6.
4 years ago

rebased onto 0bf64ca

4 years ago

3 new commits added

  • Upgrade to Vagrant 2.2.6
  • shadow-utils are no longer used in *pre* and thus not BRequired.
  • Move man pages to main package
4 years ago

Pull-Request has been closed by pvalena

4 years ago