PR#47: Add riscv64 support - rpms/wireshark

rpms / wireshark

#47 Add riscv64 support

Closed 4 months ago by jasenchao. Opened 4 months ago by jasenchao.

https://github.com/fedora-riscv/wireshark.git f39 into f39

Add riscv64 support.

JasenChao • 4 months ago

18412eb

wireshark.spec

file modified

+8 -1

		`@@ -3,10 +3,14 @@`
		`%global with_maxminddb 1`
		`%global plugins_version 4.0`

		`+ %ifarch riscv64`
		`+ %undefine __brp_check_rpaths`
		`+ %endif`
		`+`
		`Summary: Network traffic analyzer`
		`Name: wireshark`
		`Version: 4.0.12`
		`- Release: 2%{?dist}`
		`+ Release: 3%{?dist}`
		`Epoch: 1`
		`License: BSD-1-Clause AND BSD-2-Clause AND BSD-3-Clause AND MIT AND GPL-2.0-or-later AND LGPL-2.0-or-later AND Zlib AND ISC AND (BSD-3-Clause OR GPL-2.0-only) AND (GPL-2.0-or-later AND Zlib)`
		`Url: http://www.wireshark.org/`
		`@@ -280,6 +284,9 @@`
		`%{_libdir}/pkgconfig/%{name}.pc`

		`%changelog`
		`+ * Sun Jul 02 2023 Liu Yang <Yang.Liu.sn@gmail.com> - 1:4.0.12-3`
		`+ - rpath check failed on riscv64, disable it for riscv64.`
		`+`
		`* Sat Feb 17 2024 Jan Grulich <jgrulich@redhat.com> - 1:4.0.12-2`
		`- Rebuild (qt6)`

no initial comment

jasenchao commented 4 months ago

Add riscv64 support.

zuul commented 4 months ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/bac2f3ded5594928b3d5a83332922721

check-for-arches : SUCCESS in 1m 26s
rpm-scratch-build : SUCCESS in 25m 01s
rpm-scratch-build-s390x : SUCCESS in 39m 00s (non-voting)
rpm-scratch-build-ppc64le : SUCCESS in 34m 50s (non-voting)
rpm-scratch-build-i686 : SUCCESS in 26m 36s (non-voting)
rpm-scratch-build-aarch64 : SUCCESS in 19m 13s (non-voting)
rpm-linter : FAILURE in 5m 46s (non-voting)
rpm-rpminspect : FAILURE in 11m 34s (non-voting)
check-for-sti-tests : SUCCESS in 17s
check-for-fmf-tests : SUCCESS in 15s
rpm-install-test : SUCCESS in 2m 39s
rpm-tmt-test : SUCCESS in 32m 55s
Skipped 1 job

rjones commented 4 months ago

Adding @davidlt

rjones commented 4 months ago

This change needs to be targeted at rawhide, not an older branch.

rjones commented 4 months ago

The rpath check shouldn't fail, don't just disable it. What's the actual error?

davidlt commented 4 months ago

NAK. This is using CMake and you can tell CMake not to generates RPATHs. That would be a better approach.

It's failing on Fedora/RISCV Koji too, but the better approach is to tell CMake to skip RPATHS.

jasenchao commented 4 months ago

NAK. This is using CMake and you can tell CMake not to generates RPATHs. That would be a better approach.

It's failing on Fedora/RISCV Koji too, but the better approach is to tell CMake to skip RPATHS.

OK, I will close this PR, thank you.