#48 Add riscv64 support
Opened 3 months ago by jasenchao. Modified 2 months ago
https://github.com/fedora-riscv/wireshark.git rawhide  into  rawhide

Fix build.
JasenChao • 3 months ago  
wireshark.spec
file modified
+7 -1
@@ -6,7 +6,7 @@

  Summary:	Network traffic analyzer

  Name:		wireshark

  Version:	4.2.2

- Release:	3%{?dist}

+ Release:	4%{?dist}

  Epoch:		1

  License:	BSD-1-Clause AND BSD-2-Clause AND BSD-3-Clause AND MIT AND GPL-2.0-or-later AND LGPL-2.0-or-later AND Zlib AND ISC AND (BSD-3-Clause OR GPL-2.0-only) AND (GPL-2.0-or-later AND Zlib)

  Url:		http://www.wireshark.org/
@@ -125,6 +125,9 @@

  %cmake -G "Unix Makefiles" \

    -DDISABLE_WERROR=ON \

    -DBUILD_wireshark=ON \

+ %ifarch riscv64

+   -DCMAKE_SKIP_RPATH:BOOL=TRUE \

+ %endif

  %if %{with_lua} && 0%{?fedora}

    -DENABLE_LUA=ON \

  %else
@@ -280,6 +283,9 @@

  %{_libdir}/pkgconfig/%{name}.pc

  

  %changelog

+ * Fri Feb 23 2024 Jiasheng Zhao <JasenChao@gmail.com> - 1:4.2.2-4

+ - Fix build on riscv64.

+ 

  * Sun Feb 18 2024 Yaakov Selkowitz <yselkowi@redhat.com> - 1:4.2.2-3

  - Install more devel headers

  

no initial comment

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/dd40cf7f64254c8a81445a5b0b718ce7

Somehow I fail to understand, why this new boolean should be set and especially why it would help just on single platform. Do you have any publicly accessible logs from build failure on risc machine? Ideally one before this fix and another after this fix, proving this change indeed fixes the build.

I would like to see on which error it terminates without this fix.

This seems to me risc platform is not initialized in the systemd similar way as other Fedora supported platforms are. I would think this should be fixed in other package to be system-wide modification, not on every package.

Metadata