#1 Update Python 2 dependency declarations to new packaging standards
Merged 6 years ago by jskarvad. Opened 6 years ago by ishcherb.
rpms/ ishcherb/tuned pyambiguous  into  master

file modified
+11 -7
@@ -9,21 +9,21 @@ 

  Summary: A dynamic adaptive system tuning daemon

  Name: tuned

  Version: 2.9.0

- Release: 4%{?prerel1}%{?dist}

+ Release: 5%{?prerel1}%{?dist}

  License: GPLv2+

  Source0: https://github.com/redhat-performance/%{name}/archive/v%{version}%{?prerel2}.tar.gz#/%{name}-%{version}%{?prerel1}.tar.gz

  Source1: https://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git/snapshot/kvm-unit-tests-20171020.tar.gz

  URL: http://www.tuned-project.org/

  BuildArch: noarch

- BuildRequires: python, systemd, desktop-file-utils

+ BuildRequires: python2, systemd, desktop-file-utils

  BuildRequires: gcc-x86_64-linux-gnu

  Requires(post): systemd, virt-what

  Requires(preun): systemd

  Requires(postun): systemd

- Requires: python-decorator, dbus-python, pygobject3-base, python-pyudev

- Requires: virt-what, python-configobj, ethtool, gawk, hdparm

- Requires: util-linux, python2-perf, dbus, polkit, python-linux-procfs

- Requires: python-schedutils

+ Requires: python2-decorator, python2-dbus, python2-gobject-base, python2-pyudev

+ Requires: virt-what, python2-configobj, ethtool, gawk, hdparm

+ Requires: util-linux, python2-perf, dbus, polkit, python2-linux-procfs

+ Requires: python2-schedutils

  %if 0%{?fedora} > 22 || 0%{?rhel} > 7

  Recommends: kernel-tools

  %endif
@@ -48,7 +48,7 @@ 

  %package gtk

  Summary: GTK GUI for tuned

  Requires: %{name} = %{version}-%{release}

- Requires: powertop, pygobject3-base, polkit

+ Requires: powertop, python2-gobject-base, polkit

  

  %description gtk

  GTK GUI that can control tuned and provides simple profile editor.
@@ -404,6 +404,10 @@ 

  %{_mandir}/man7/tuned-profiles-compat.7*

  

  %changelog

+ * Mon Feb 05 2018 Iryna Shcherbina <ishcherb@redhat.com> - 2.9.0-5

+ - Update Python 2 dependency declarations to new packaging standards

+   (See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3)

+ 

  * Wed Jan 31 2018 Jaroslav Škarvada <jskarvad@redhat.com> - 2.9.0-4

  - Fixed perf requirement, explicitly require python2-perf

  

This package uses names with ambiguous python- prefix in requirements.

According to Fedora Packaging guidelines for Python, packages must use names with either python2- or python3- prefix in requirements where available.
We are aiming to rename python-* dependencies to python2-*, so we can later switch the python-* namespace to Python 3.

This PR is part of Fedora's Switch to Python 3 effort.

Note that, although this PR was created automatically, we will respond to any comments or issues which you might find with it. We will keep the PR open for review for a week, and if there's no feedback we'll merge it. There is no need to build the package right after merge, this change can wait for the next package rebuild.
The local mock build passed, for Koji scratch build please see simple-koji-ci result.

Note: please do not backport this to f26, f27 branch(es) as some of the modified requirements are not available there

This PR was opened automatically, for source code see here

Thanks for the PR. FYI we have already fixed it in the upstream and moreover we added full native python3 support to the Tuned package. We would like to switch to the python3 as default, but at the moment the kernel perf is blocking us from doing it. FYI the kernel-tools ticket: https://bugzilla.redhat.com/show_bug.cgi?id=1536656

Upstream Tuned git with the changes:
https://github.com/redhat-performance/tuned/commits/master

Pull-Request has been merged by jskarvad

6 years ago

That is good news, thanks for the information and effort!