Blob Blame History Raw
From fcc5bac3264420de0203589753b732da1dbc27bb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
Date: Wed, 14 May 2014 16:42:24 +0200
Subject: [PATCH] Sort inconsistent declarations for error message
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Random hash key ordering casues test failures. It's also good to have
stable output for human error messages.

https://rt.cpan.org/Public/Bug/Display.html?id=95642
Signed-off-by: Petr Písař <ppisar@redhat.com>
---
 lib/Class/AutoClass.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Class/AutoClass.pm b/lib/Class/AutoClass.pm
index 1d7337a..83fd07a 100644
--- a/lib/Class/AutoClass.pm
+++ b/lib/Class/AutoClass.pm
@@ -530,7 +530,7 @@ sub declare {
  @cattributes_recursive{keys %cattributes}=values %cattributes;
  push(@attributes_recursive,keys %iattributes,keys %cattributes);
  # are all these declarations consistent?
- if (my @inconsistents=grep {exists $cattributes_recursive{$_}} keys %iattributes_recursive) {
+ if (my @inconsistents=sort grep {exists $cattributes_recursive{$_}} keys %iattributes_recursive) {
    # inconsistent class vs. instance declarations
    my @errstr=("Inconsistent declarations for attribute(s) @inconsistents");
    map {
-- 
1.9.0